New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Contextual Menus #174

Open
lime124 opened this Issue Jan 16, 2019 · 8 comments

Comments

Projects
None yet
5 participants
@lime124
Copy link

lime124 commented Jan 16, 2019

User Story:
As a user I want options for manipulating things I find on the web including images, links, and text.

Current Design Status:

  • No Fenix specific work done on this
  • Have prior reference from Fennec and Focus

Design Priority:
P1

@brampitoyo brampitoyo self-assigned this Jan 17, 2019

@bbinto

This comment has been minimized.

Copy link
Collaborator

bbinto commented Jan 18, 2019

Tif, please provide ETA for this (cc @brampitoyo)

@bbinto bbinto added P1 and removed Non-Eng labels Jan 18, 2019

@bbinto bbinto added this to the UX Backlog milestone Jan 18, 2019

@shorlander

This comment has been minimized.

Copy link
Collaborator

shorlander commented Jan 18, 2019

Guessing an M size, but @brampitoyo might disagree.

@lime124

This comment has been minimized.

Copy link
Author

lime124 commented Jan 18, 2019

@bbinto - Bram is out until the 28th. He can probably work on this when he returns, but he's also going to be joining Amazon TV/Show at that time. I don't feel comfortable providing a concrete deadline on his behalf without checking in with him first. Sorry I don't have a more concrete answer.

@bbinto

This comment has been minimized.

Copy link
Collaborator

bbinto commented Jan 21, 2019

Thanks Tif - these are primary user controls, can somebody else pick this up? Seems pretty basic and needed for the MVP.

@bbinto

This comment has been minimized.

Copy link
Collaborator

bbinto commented Jan 23, 2019

@vesta0 and @shorlander , @st3fan to meet and discuss if current refbrowser implementation is acceptable for milestone 2.

@brampitoyo

This comment has been minimized.

Copy link
Collaborator

brampitoyo commented Jan 29, 2019

I’ve identified 4 different situations where a contextual menu can appear:

1. On tap + hold link

The context menu contains:

  • Open in new tab
  • Copy link
  • Copy link text
  • Share link

2. On tap + hold image

The context menu contains:

  • Open in new tab
  • Save image
  • Copy link
  • Share image

3. On tap + hold text

The text selection toolbar (note that it’s not a modal dialogue) contains:

  • Copy
  • Share
  • Select all

4. On tap + hold address bar

In this situation, Fenix should behave as if the address bar has been tapped. This means that:

  1. The URL is highlighted
  2. The keyboard is up
  3. A grey shade is shown over the web content

The text selection toolbar contains:

  • Cut
  • Copy
  • Paste
  • Share

@brampitoyo

This comment has been minimized.

Copy link
Collaborator

brampitoyo commented Jan 29, 2019

@colintheshots This issue is now ready for your feedback, and to estimate.

@pocmo

This comment has been minimized.

Copy link
Collaborator

pocmo commented Jan 29, 2019

Also see #264: This functionality is provided by a component.

Note that case 3 and 4 above are system level text selection toolbars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment