Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Create smoke test to prevent start up crashes when device doesn't have network access #18040

Closed
mcomella opened this issue Feb 18, 2021 · 0 comments · Fixed by #18112
Closed
Assignees
Labels
performance Possible performance wins

Comments

@mcomella
Copy link
Contributor

mcomella commented Feb 18, 2021

This is very similar to #18041 The distinction is that this bug is for no network access; that bug is for network access but bad results.

We experienced a start up crash when the device was without network access: #16886 afaict, this was fixed in the nimbus SDK mozilla/nimbus-sdk#67 but there wasn't any generic smoke test put in place to prevent this class of errors (crashes due to having no network access for start up or other UI flows). We should add such a test. This test could be automated or added to the manual QA test plan (then again if it was done manually, it'd still cause our perftests too fail (below) so maybe it's only sufficient if, when we see such crashes, that the perf team is notified directly).

To be explicit, this is not something the performance team intends to work on in the short term but it's important to us because crashes like these cause our performance tests in mozilla-central to fail, which disrupts our engineers' work stream as we investigate such crashes and possibly missing the cause of regressions as we lose performance test data.

┆Issue is synchronized with this Jira Task

@mcomella mcomella added the performance Possible performance wins label Feb 18, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 18, 2021
@sv-ohorvath sv-ohorvath self-assigned this Feb 18, 2021
@sv-ohorvath sv-ohorvath removed the needs:triage Issue needs triage label Feb 18, 2021
@sv-ohorvath sv-ohorvath linked a pull request Feb 22, 2021 that will close this issue
3 tasks
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
performance Possible performance wins
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants