Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Accounts menu in tabs tray shows settings even if not signed in #19094

Closed
jonalmeida opened this issue Apr 17, 2021 · 0 comments · Fixed by #19119
Closed

Accounts menu in tabs tray shows settings even if not signed in #19094

jonalmeida opened this issue Apr 17, 2021 · 0 comments · Fixed by #19119
Assignees
@jonalmeida
Labels
🐞 bug Crashes, Something isn't working, .. E1 Estimation Point: trivial, less than half day Feature:SyncTabs Sync tabs Feature:Tabs MR1 Issues that are needed for the MR1 2021 release.
Projects
Tabs Tray Refactor

Comments

@jonalmeida
Copy link
Contributor

jonalmeida commented Apr 17, 2021 •
edited by data-sync-user

Steps to reproduce

  1. Ensure that no account in logged in.
  2. Open the tabs tray.
  3. Swipe to Synced Tabs page.
  4. Open the menu and click on 'Account Settings'

Expected results

  • We are taken to the login/sign screen because there is no account signed in.

Actual results

  • We are taken to a blank account settings page that is not attached to any account.

┆Issue is synchronized with this Jira Task
@jonalmeida jonalmeida created this issue from a note in Tabs Tray Refactor (Backlog) Apr 17, 2021
@jonalmeida jonalmeida added Feature:SyncTabs Sync tabs Feature:Tabs E1 Estimation Point: trivial, less than half day MR1 Issues that are needed for the MR1 2021 release. labels Apr 17, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 17, 2021
@jonalmeida jonalmeida added 🐞 bug Crashes, Something isn't working, .. and removed needs:triage Issue needs triage labels Apr 17, 2021
@jonalmeida jonalmeida self-assigned this Apr 19, 2021
@jonalmeida jonalmeida moved this from Backlog to In progress in Tabs Tray Refactor Apr 19, 2021
jonalmeida added a commit to jonalmeida/fenix that referenced this issue Apr 19, 2021
@jonalmeida
Close mozilla-mobile#19094: Open sign-in flow if no account is create…
94f5bcc 
…d for tabs tray
Tabs Tray Refactor automation moved this from In progress to Done Apr 19, 2021
@jonalmeida jonalmeida linked a pull request Apr 19, 2021 that will close this issue
Close #19094: Open sign-in flow if no account is created for tabs tray #19119
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jonalmeida jonalmeida

Labels
🐞 bug Crashes, Something isn't working, .. E1 Estimation Point: trivial, less than half day Feature:SyncTabs Sync tabs Feature:Tabs MR1 Issues that are needed for the MR1 2021 release.
Projects
No open projects
Tabs Tray Refactor
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Close #19094: Open sign-in flow if no account is created for tabs tray jonalmeida/fenix
1 participant
@jonalmeida