[Bug]: Filename in "Open" PDF dialog overflows screen

[mcomella]

Steps to reproduce

• Visit http://shawnodonnells.com
• Click "Lunch/Dinner Menu" (may require scroll down)
• Click "Download"
• Wait for download to complete

Expected behaviour

Filename fits in dialog

Actual behaviour

Filename overflows "Open" dialog (this doesn't affect earlier "Download" dialog)

Device name

Moto G5

Android version

?

Firefox release type

Firefox Nightly

Firefox version

Nightly 10/8

Device logs

No response

Additional information

No response

┆Issue is synchronized with this Jira Task

[LaurentiuApahideanSV]

I tested the issue on Firefox Preview Nightly 2021-11-02. I was able to reproduce it, however the issue also occurs on Chrome.

Devices used:

• Oppo Find X3 (Android 11)
• OnePlus 6T (Android 9)

[Taknok]

This PR #22325 breaks the default MAX_PATH on Windows (260 chars). Thus, the repo cannot be cloned anymore on Windows 10 if you do not increase the value. (To be precise, main branch cannot be checkout).

To increase the max value, run the following powershell command and reboot:

New-ItemProperty -Path "HKLM:\SYSTEM\CurrentControlSet\Control\FileSystem" `
-Name "LongPathsEnabled" -Value 1 -PropertyType DWORD -Force

Source: https://docs.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=powershell

[grigoryk]

This PR #22325 break the default MAX_PATH on Windows (260 chars). Thus, the repo cannot be cloned anymore on Windows 10 if you do not increase the value. (To be precise, main branch cannot be checkout).

To increase the max value, run the following powershell command and reboot:

New-ItemProperty -Path "HKLM:\SYSTEM\CurrentControlSet\Control\FileSystem" `
-Name "LongPathsEnabled" -Value 1 -PropertyType DWORD -Force

Source: https://docs.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=powershell

Thanks, @Taknok ! That was unintentional, of course.
cc @mavduevskiy can you adjust the test file to be under the limit?

[grigoryk]

Should be fixed by #22354

[mavduevskiy]

I am a bit puzzled on what to do. The very idea behind adding a file with such a long name was to test if the app can properly display downloaded file with max possible name length. Which happens to be in the range of 250-260. Which happens to be also the max path name in Windows systems. While on MacOS it is 1024, and on Linux 4096.

Shouldn't the most of developers working on Widnows increase the max path length? Having max path length the same as max file name length on most of the systems is prone to errors. Even if we cut the file name in half, some windows users might still run into the same problem if they have a long project folder path on its own.

Not holding any strong opinions though. Just want to find balance between the need to test displaying of max length file names and adjusting to Windows system requirements.
@Taknok @grigoryk

[Taknok]

I share your feelings. I report this as a remark, in order to be sure everyone was aware.
Windows is quite a pain to have a path length that short, but preventing someone since the begging to clone (checkout in reality) the main branch or event unzip the archive makes me uncomfortable, but it is a valid choice for Fenix's team. So I see 2 options here:

• Set a paragraph in the Readme.md to warn for windows env that user/dev should increase max path length and reboot before cloning.
• Generate the file to download programmatically (thus, the file will not be in the repo) and set a check in graddle to check max path length and ask user/dev to increase the limit. If not done, the test will only failed on windows environment.

Another option would be to change the filename length according to environment, but I do not like this idea.

Joke: But why does anybody sane want to dev on Windows ?

[grigoryk]

#22354 landed, I confirmed that this fixed git clone of the project on my Windows machine.

[sflorean]

Verified as fixed on latest Nightly build, with LG G7 Fit (Android 8.1).