Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Telemetry for History Management #2362

Closed
sblatz opened this issue May 8, 2019 · 7 comments
Closed

Telemetry for History Management #2362

sblatz opened this issue May 8, 2019 · 7 comments
Assignees
Labels
E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified Feature:History Feature:Telemetry
Milestone

Comments

@sblatz
Copy link
Contributor

sblatz commented May 8, 2019

Description & Product Manager / Data Scientist User Story

As a product owner, I want to track the usage of history management section in Fenix so that I can understand how our users leverage this feature, and detect anomalies or issues in user flow and usage.

Hypothesis

We believe this feature is useful to users, and successful when

  • % of users browsing history increases
  • % of users opening website via history section

What questions will you answer with this data?

  • How often do users open the history section?
  • Do users delete or share a previously visited site?
  • Do users open a previously visited site in a new regular or private tab?
  • Do users delete all history?

What probes

  • History section opened
  • History items deleted or shared
  • History items opened in a new regular or private tab
  • Tap on delete all history

Dependencies (Added by PM and Eng)

  • Glean SDK (Event ping)

Acceptance Criteria

  • Event pings can be queried via re:dash
  • We are sending telemetry events for the actions listed in the requirements
  • We have documented the telemetry
  • We have asked a data steward to review the telemetry

NOT an AC: Data science to create dashboard or further graphs (this will be a separate issue, this issue is only about hooking up the events described and that they can be queried in re-dash)

┆Issue is synchronized with this Jira Task

@sblatz
Copy link
Contributor Author

sblatz commented May 8, 2019

@vesta0 will likely want to create this data request.

@vesta0 vesta0 self-assigned this May 10, 2019
@vesta0 vesta0 added this to the MVP Backlog milestone May 10, 2019
@vesta0 vesta0 added P2 Upcoming release Feature:History and removed needs:product labels May 10, 2019
@vesta0 vesta0 removed their assignment May 16, 2019
@bifleming bifleming added the Release Blocker Blocks a Release label May 17, 2019
@vesta0 vesta0 removed the Release Blocker Blocks a Release label May 17, 2019
@vesta0 vesta0 removed P2 Upcoming release labels Jun 7, 2019
@vesta0 vesta0 added the P1 Current sprint label Jul 2, 2019
@vesta0 vesta0 added must and removed P1 Current sprint labels Jul 3, 2019
@vesta0 vesta0 changed the title [Telemetry] History Management Telemetry for History Management Jul 3, 2019
@AndiAJ
Copy link
Collaborator

AndiAJ commented Jul 17, 2019

Hi, the History Management telemetry still doesn't work properly on the latest Nightly Build #11980613.

What works ✅

• History section opened
• History items deleted or shared
• Delete all history

Logcat

Dashboard

What doesn't seem to be working ❌

► History items opened in a new regular or private tab
I've used the following steps:

  1. Perform a search - Ping 8b7d8084-62a0-4c50-9f84-6d44a1f66760
  2. Navigate to History - Ping 48e7cecb-eca5-4521-90ce-d6b71e9ffc68
  3. Select a history item
  4. Open in private tab - Ping 8b0e2338-b0f3-4906-9b25-83b07d237976
  5. Switch back - Ping 12e7af78-1b87-4906-b653-feb52b72c1be
  6. Go to history - Ping 2fd7824d-8f98-4a9c-bb39-d7da1d3288aa
  7. Open in new tab - ❌no ping generated

Logcat
Dashboard

► Delete a single history item using the 3dot button
❌No ping is generated
20190717_163055

@sblatz - Could you also please confirm if the Open in private tab events ping was correctly generated?

sblatz added a commit to sblatz/fenix that referenced this issue Jul 18, 2019
@sblatz sblatz added eng:qa:needed QA Needed and removed in progress labels Jul 18, 2019
@colintheshots colintheshots modified the milestones: 1.1 Backlog, v1.1 Jul 23, 2019
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jul 24, 2019
@AndiAJ
Copy link
Collaborator

AndiAJ commented Jul 24, 2019

Hi, I've retested the History Management telemetry and it looks like it works fine on the latest Nightly Build #190724 from 24/7.

Actions using single history item

• History section opened Ping 9535edce-27be-49df-b979-bb7c7f43e9f1
• History items deleted or shared Ping d67235aa-6470-4c7e-a591-8806a039bee0
• History items opened in a new regular Ping f40cece6-d2b5-4f7a-9af7-9991ee2c8b48
• History items opened private tab Ping 8f89164e-41ea-4726-ac20-3ce773e47d92
• Delete all history Ping d8b02dc7-59ec-49c5-ba3b-f20dfb62b41a

Logcat
Glean Dashboard

Actions using multiple history items

• History section opened Ping d367292e-9d65-47fa-b8ef-f4821bbd0767
• History items deleted or shared Ping a08439c8-d585-41f3-9de2-9e0db5ababaa
• History items opened in a new regular Ping 4921a975-30e3-4b7f-bff3-d1ee1df7ad7e
• History items opened private tab Ping 619bf6c1-8d99-47e1-8135-f7d3a3cca2a6
• Delete all history Ping fa0cefef-52b3-422c-8403-d251a486611d

Logcat
Glean Dashboard

But before closing this ticket I would highly appreciate if @boek & @sblatz could help me clarify some aspects regarding the opening of history items in private tabs:

• To recognize a history item opened in a private tab should we relate only on the switch from normal to private browsing ?

Example from Ping 8f89164e-41ea-4726-ac20-3ce773e47d92

"category": "events",
"name": "app_opened",
"extra": {
"source": "APP_ICON"

• Why do we have in both single & multiple History items opened private tab 2x library closed and 2x history opened?

Example from Ping 8f89164e-41ea-4726-ac20-3ce773e47d92 (Single history item opened in PB) { "events": [ { "timestamp": 0, "category": "history", "name": "opened_item" }, { "timestamp": 65, "category": "library", "name": "closed" }, { "timestamp": 66, "category": "library", "name": "closed" }, { "timestamp": 104, "category": "history", "name": "opened" }, { "timestamp": 104, "category": "history", "name": "opened" }, { "timestamp": 117, "category": "events", "name": "app_opened", "extra": { "source": "APP_ICON" }

I'll remove the QA needed label, and will close it after your confirmation.

@AndiAJ AndiAJ removed the eng:qa:verified QA Verified label Jul 26, 2019
@sblatz
Copy link
Contributor Author

sblatz commented Jul 26, 2019

To recognize a history item opened in a private tab should we relate only on the switch from normal to private browsing ?
I think this seems reasonable.

Why do we have in both single & multiple History items opened private tab 2x library closed and 2x history opened?

This is happening because we're changing the theme which requires the app to recreate. Unfortunately I don't think there's a way around it.

@boek what are your thoughts on this?

@sblatz sblatz added the E3 Estimation Point: average, 2 - 3 days label Jul 27, 2019
@sblatz
Copy link
Contributor Author

sblatz commented Aug 1, 2019

Bumping @boek on this :)

@AndiAJ
Copy link
Collaborator

AndiAJ commented Aug 2, 2019

Hi verified as fixed on RC 1.2-rc2 using a Google Pixel 3a (Android 9).

Actions using single history item

• History section opened Ping 92f947ec-1586-484e-b519-68319bbc3964
• History item deleted 3dot button Ping bc1b743f-c193-4a0b-a723-b17c19a2d5b1
• History items deleted or shared Ping f633c7a4-a6a9-4c9b-87f4-c06b5dd7ad8c
• History items opened in a new regular Ping 9b45cee5-afca-41f1-b6c9-5e57463e9c7b
• History items opened private tab Ping 9ef1e09b-4983-4822-aaf3-b168068d3844

Logcat
Glean Dashboard

Actions using multiple history item

• History section opened Ping 7c0c041f-6e98-45c5-ab5d-708a1a067298
• History items deleted or shared Ping 0e4a8a76-221f-4818-aa6f-22cfe5959a78
• History items opened in a new regular Ping d085cc36-81b3-4898-9bab-214c172c4e2f
• History items opened private tab Ping 5c515c77-6d26-4e49-80ba-3fd10a5b1ff1
• Delete all history Ping 66d1f363-8b6f-4d29-8695-9b24323e04d2

Logcat
Glean Dashboard

@boek - It would be great to clarify the above mentioned two aspects.

@AndiAJ AndiAJ added the eng:qa:verified QA Verified label Aug 2, 2019
@liuche liuche added this to the v1.2 milestone Aug 2, 2019
@boek
Copy link
Contributor

boek commented Aug 2, 2019

@AndiAJ unfortunately that is correct. I filed #4509 to track/follow up later

@boek boek closed this as completed Aug 2, 2019
@data-sync-user data-sync-user changed the title Telemetry for History Management FNX2-17930 ⁃ Telemetry for History Management Aug 5, 2020
@data-sync-user data-sync-user changed the title FNX2-17930 ⁃ Telemetry for History Management FNX3-16259 ⁃ Telemetry for History Management Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-16259 ⁃ Telemetry for History Management FNX-5616 ⁃ Telemetry for History Management Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-5616 ⁃ Telemetry for History Management Telemetry for History Management May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified Feature:History Feature:Telemetry
Projects
None yet
Development

No branches or pull requests

8 participants