Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]: The Firefox Homepage Messaging Banner is still displayed after Fenix is set as default browser until a restart is made #25187

Closed
LaurentiuApahideanSV opened this issue May 10, 2022 · 1 comment
Closed

[Bug]: The Firefox Homepage Messaging Banner is still displayed after Fenix is set as default browser until a restart is made #25187

LaurentiuApahideanSV opened this issue May 10, 2022 · 1 comment
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:HomeScreen needs:triage Issue needs triage S3 Blocks non-critical functionality and a work around exists

Comments

@LaurentiuApahideanSV
Copy link

LaurentiuApahideanSV commented May 10, 2022 •
edited by data-sync-user

Steps to reproduce

Preconditions: Make sure Fenix is not set as Default browser in Device settings.

  1. Launch Fenix;
  2. Navigate to the Homepage;
  3. Tap the "Set as default" button from the Firefox Homepage Messaging Banner;
  4. Set Firefox as the default browser application.

Expected behaviour

The Firefox Homepage Messaging Banner should be dismissed.

Actual behaviour

The Firefox Homepage Messaging Banner in not dismissed and a restart of Firefox is needed.

Device name

Google Pixel 6

Android version

Android 13

Firefox release type

Firefox

Firefox version

100.1.2

Device logs

No response

Additional information

20220510_161214.mp4

┆Issue is synchronized with this Jira Task
@LaurentiuApahideanSV LaurentiuApahideanSV added 🐞 bug Crashes, Something isn't working, .. Feature:HomeScreen S3 Blocks non-critical functionality and a work around exists needs:triage Issue needs triage labels May 10, 2022
Amejia481 added a commit to Amejia481/fenix that referenced this issue May 10, 2022
@Amejia481
For mozilla-mobile#25187: Dismiss the default browser card after clic…
30e97de 
…king.
Amejia481 added a commit that referenced this issue May 10, 2022
@Amejia481
For #25187: Dismiss the default browser card after clicking.
2da352f
@delia-pop
Copy link

Verified as fixed on the latest RC 100.3.0 with Motorola Moto G30 (Android 11) and Google Pixel 6 (Android 13). After selecting Fenix as default app using the banner, the messaging banner is dismissed right away.

@delia-pop delia-pop added the eng:qa:verified QA Verified label May 20, 2022
lillabldv added a commit to karmaSearch/fenix that referenced this issue Jun 11, 2022
@lillabldv
Merge commit '827b01341f76e9ee8c152260992eb5f22a775791' into merge/100.3
36f61c1 
* commit '827b01341f76e9ee8c152260992eb5f22a775791': (792 commits)
  Automatic version bump CLOSED TREE NO BUG a=release
  Update to Android-Components 100.0.12. (mozilla-mobile#25307)
  Bump version to 100.3.0
  Automatic version bump CLOSED TREE NO BUG a=release
  Bump version to 100.2.0
  Automatic version bump CLOSED TREE NO BUG a=release
  Update to Android-Components 100.0.11. (mozilla-mobile#25235)
  For mozilla-mobile#25187: Dismiss the default browser card after clicking.
  Automatic version bump CLOSED TREE NO BUG a=release
  Set default browser banner location to homescreen-banner
  Automatic version bump CLOSED TREE NO BUG a=release
  Update to Android-Components 100.0.10. (mozilla-mobile#25023)
  Automatic version bump CLOSED TREE NO BUG a=release
  Update to Android-Components 100.0.9. (mozilla-mobile#24956)
  Bump version to 100.1.0
  Strings - app/src/main/res/values-tg/strings.xml
  Strings - app/src/main/res/values-oc/strings.xml
  for mozilla-mobile#24929: remove locale restriction for remote firefox wallpapers (mozilla-mobile#24938)
  Strings - app/src/main/res/values-sl/strings.xml
  Strings - app/src/main/res/values-ja/strings.xml
  ...

# Conflicts:
#	app/build.gradle
#	app/metrics.yaml
#	app/src/androidTest/java/org/mozilla/fenix/ui/SettingsBasicsTest.kt
#	app/src/androidTest/java/org/mozilla/fenix/ui/SmokeTest.kt
#	app/src/androidTest/java/org/mozilla/fenix/ui/robots/HomeScreenRobot.kt
#	app/src/main/java/org/mozilla/fenix/FeatureFlags.kt
#	app/src/main/java/org/mozilla/fenix/FenixApplication.kt
#	app/src/main/java/org/mozilla/fenix/HomeActivity.kt
#	app/src/main/java/org/mozilla/fenix/addons/AddonsManagementFragment.kt
#	app/src/main/java/org/mozilla/fenix/components/Core.kt
#	app/src/main/java/org/mozilla/fenix/components/toolbar/BrowserToolbarView.kt
#	app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt
#	app/src/main/java/org/mozilla/fenix/experiments/NimbusFeatures.kt
#	app/src/main/java/org/mozilla/fenix/ext/String.kt
#	app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt
#	app/src/main/java/org/mozilla/fenix/home/HomeFragmentStore.kt
#	app/src/main/java/org/mozilla/fenix/home/HomeMenu.kt
#	app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlAdapter.kt
#	app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlInteractor.kt
#	app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlView.kt
#	app/src/main/java/org/mozilla/fenix/home/topsites/TopSiteItemViewHolder.kt
#	app/src/main/java/org/mozilla/fenix/search/toolbar/ToolbarView.kt
#	app/src/main/java/org/mozilla/fenix/settings/HomeSettingsFragment.kt
#	app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt
#	app/src/main/java/org/mozilla/fenix/share/ShareViewModel.kt
#	app/src/main/java/org/mozilla/fenix/tabstray/FloatingActionButtonBinding.kt
#	app/src/main/java/org/mozilla/fenix/tabstray/TabLayoutMediator.kt
#	app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayInactiveTabsOnboardingBinding.kt
#	app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayMenu.kt
#	app/src/main/java/org/mozilla/fenix/tabstray/TrayPagerAdapter.kt
#	app/src/main/java/org/mozilla/fenix/theme/FirefoxTheme.kt
#	app/src/main/java/org/mozilla/fenix/utils/Settings.kt
#	app/src/main/res/color/toggle_text_color.xml
#	app/src/main/res/drawable/button_background.xml
#	app/src/main/res/drawable/home_search_background.xml
#	app/src/main/res/drawable/ic_desktop.xml
#	app/src/main/res/drawable/ic_download.xml
#	app/src/main/res/drawable/ic_history.xml
#	app/src/main/res/drawable/ic_search.xml
#	app/src/main/res/drawable/onboarding_popup_shape.xml
#	app/src/main/res/layout/activity_migration.xml
#	app/src/main/res/layout/component_collection_creation.xml
#	app/src/main/res/layout/component_tracking_protection_panel.xml
#	app/src/main/res/layout/fragment_home.xml
#	app/src/main/res/layout/mp_migration_dialog.xml
#	app/src/main/res/layout/mp_migration_done_dialog.xml
#	app/src/main/res/layout/onboarding_inactive_tabs_cfr.xml
#	app/src/main/res/layout/onboarding_jump_back_in_cfr.xml
#	app/src/main/res/layout/search_widget_extra_small_v1.xml
#	app/src/main/res/layout/search_widget_large.xml
#	app/src/main/res/layout/search_widget_small.xml
#	app/src/main/res/layout/share_tab_item.xml
#	app/src/main/res/values-br/strings.xml
#	app/src/main/res/values-cy/strings.xml
#	app/src/main/res/values-de/strings.xml
#	app/src/main/res/values-dsb/strings.xml
#	app/src/main/res/values-el/strings.xml
#	app/src/main/res/values-en-rCA/strings.xml
#	app/src/main/res/values-en-rGB/strings.xml
#	app/src/main/res/values-eo/strings.xml
#	app/src/main/res/values-es-rAR/strings.xml
#	app/src/main/res/values-es-rCL/strings.xml
#	app/src/main/res/values-es-rMX/strings.xml
#	app/src/main/res/values-et/strings.xml
#	app/src/main/res/values-eu/strings.xml
#	app/src/main/res/values-fi/strings.xml
#	app/src/main/res/values-fr/strings.xml
#	app/src/main/res/values-fy-rNL/strings.xml
#	app/src/main/res/values-gl/strings.xml
#	app/src/main/res/values-hsb/strings.xml
#	app/src/main/res/values-hu/strings.xml
#	app/src/main/res/values-hy-rAM/strings.xml
#	app/src/main/res/values-ia/strings.xml
#	app/src/main/res/values-in/strings.xml
#	app/src/main/res/values-it/strings.xml
#	app/src/main/res/values-iw/strings.xml
#	app/src/main/res/values-ja/strings.xml
#	app/src/main/res/values-ka/strings.xml
#	app/src/main/res/values-kab/strings.xml
#	app/src/main/res/values-kk/strings.xml
#	app/src/main/res/values-ko/strings.xml
#	app/src/main/res/values-lt/strings.xml
#	app/src/main/res/values-my/strings.xml
#	app/src/main/res/values-night/colors.xml
#	app/src/main/res/values-nl/strings.xml
#	app/src/main/res/values-nn-rNO/strings.xml
#	app/src/main/res/values-oc/strings.xml
#	app/src/main/res/values-pa-rIN/strings.xml
#	app/src/main/res/values-pl/strings.xml
#	app/src/main/res/values-pt-rBR/strings.xml
#	app/src/main/res/values-rm/strings.xml
#	app/src/main/res/values-ru/strings.xml
#	app/src/main/res/values-sat/strings.xml
#	app/src/main/res/values-sk/strings.xml
#	app/src/main/res/values-sl/strings.xml
#	app/src/main/res/values-sv-rSE/strings.xml
#	app/src/main/res/values-ta/strings.xml
#	app/src/main/res/values-tg/strings.xml
#	app/src/main/res/values-tr/strings.xml
#	app/src/main/res/values-trs/strings.xml
#	app/src/main/res/values-uk/strings.xml
#	app/src/main/res/values-vi/strings.xml
#	app/src/main/res/values-zh-rCN/strings.xml
#	app/src/main/res/values-zh-rTW/strings.xml
#	app/src/main/res/values/attrs.xml
#	app/src/main/res/values/colors.xml
#	app/src/main/res/values/dimens.xml
#	app/src/main/res/values/preference_keys.xml
#	app/src/main/res/values/static_strings.xml
#	app/src/main/res/values/strings.xml
#	app/src/main/res/values/styles.xml
#	app/src/release/res/values/colors.xml
#	app/src/test/java/org/mozilla/fenix/home/SessionControlInteractorTest.kt
#	app/src/test/java/org/mozilla/fenix/home/sessioncontrol/SessionControlViewTest.kt
#	app/src/test/java/org/mozilla/fenix/share/ShareViewModelTest.kt
#	buildSrc/src/main/java/AndroidComponents.kt
#	buildSrc/src/main/java/Dependencies.kt
#	version.txt
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:HomeScreen needs:triage Issue needs triage S3 Blocks non-critical functionality and a work around exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LaurentiuApahideanSV @delia-pop