Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL containing spaces are treated as search terms #3306

Open
glandium opened this issue Jun 9, 2019 · 4 comments

Comments

Projects
None yet
4 participants
@glandium
Copy link

commented Jun 9, 2019

Steps to reproduce

Expected behavior

Actual behavior

You might wonder why the hell one would open an url with spaces in them. Well, originally here's what happened to me: I opened the search/address bar, and used the QR code scanner, to scan a QR code. The url the QR code decoded to contained spaces. So I was brought to a google search rather than what I was supposed to see.

Device information

  • Android device: Nexus 5
  • Fenix version: 1.0.1923 (Build #11590615 68.0-20190604110028)

@glandium glandium added the 🐞 bug label Jun 9, 2019

@vesta0

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

@glandium I assume you were expecting http://example.com/foo%20bar ?

@glandium

This comment has been minimized.

Copy link
Author

commented Jun 11, 2019

I guess so, the url I got from the QR code does work if I replace the spaces with %20.

@colintheshots

This comment has been minimized.

Copy link
Collaborator

commented Jun 12, 2019

URLs cannot contain spaces. Spaces can only be URL-encoded as %20. https://www.ietf.org/rfc/rfc1738.txt

The issue is that the QR reader is not URL-encoding an otherwise valid URL.

@kbrosnan kbrosnan changed the title [Bug] URL containing spaces are treated as search terms URL containing spaces are treated as search terms Jun 12, 2019

@kbrosnan

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

Firefox, Chrome and Edge on desktop handle http://example.com/foo bar doing the %20 escaping for the user. We should add this user convenience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.