Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]Add undo option when deleting a bookmark from edit mode #5010

Closed
AndiAJ opened this issue Aug 29, 2019 · 7 comments
Closed

[Bug]Add undo option when deleting a bookmark from edit mode #5010

AndiAJ opened this issue Aug 29, 2019 · 7 comments
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Bookmarks Feature:Snackbar P3 Some future sprint S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist wontfix

Comments

@AndiAJ
Copy link
Collaborator

AndiAJ commented Aug 29, 2019

Prerequisites

Have a couple of bookmarks saved.

Steps to reproduce

  1. Tap to edit one of the bookmarks
  2. Delete the bookmark using the upper right trash bin icon image
  3. Check the deletion confirmation snackbar

Expected behavior

Undo option should be available from the snackbar

Actual behavior

No undo option is available

Device information

  • Android device:
    Google Pixel 3a (Android 9)
    OnePlus A3 (Android 6.0.1)
  • Fenix version: Nightly Build #12410626 from 29/8

Notes

The confirmation snackbar was implemented in #4488

► Video with the snackbar when deleting a bookmark from edit mode
Working

► Video wih the snackbar when deleting a bookmark in normal mode
undo

┆Issue is synchronized with this Jira Task

@AndiAJ AndiAJ added 🐞 bug Crashes, Something isn't working, .. S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist Feature:Bookmarks Feature:Snackbar labels Aug 29, 2019
@shahsurajk
Copy link
Contributor

Wouldn't undo break the flow?

As mentioned the in the PR as well, here:

This doesn't make use of Undo.allowUndo as we already show a dialog for user confirmation, giving an option to undo, might break the flow (comments on this are welcomed).

Wouldn't the UX be a bit off?

@AndiAJ
Copy link
Collaborator Author

AndiAJ commented Aug 29, 2019

Hi @shahsurajk , not sure, I've thought that if the undo option is available when deleting a bookmark from the normal view, it should be available in edit mode as well.
@boek Could you please share your thoughts on this matter? :)

@boek boek added the P3 Some future sprint label Dec 28, 2019
@stale
Copy link

stale bot commented Feb 5, 2021

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 5, 2021
@stale stale bot closed this as completed Feb 12, 2021
@AndiAJ
Copy link
Collaborator Author

AndiAJ commented Feb 17, 2021

Still reproducible on 86.1.0 RC1 using a OnePlus A3 (Android 6.0.1)

@AndiAJ AndiAJ reopened this Feb 17, 2021
@stale stale bot removed the wontfix label Feb 17, 2021
@stale
Copy link

stale bot commented Aug 16, 2021

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 16, 2021
@stale stale bot closed this as completed Aug 23, 2021
@AndiAJ
Copy link
Collaborator Author

AndiAJ commented Nov 3, 2021

Still reproducible on Firefox 95.0.0 Beta 1

@AndiAJ AndiAJ reopened this Nov 3, 2021
@stale stale bot removed the wontfix label Nov 3, 2021
@stale
Copy link

stale bot commented May 2, 2022

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 2, 2022
@stale stale bot closed this as completed May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Bookmarks Feature:Snackbar P3 Some future sprint S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist wontfix
Projects
None yet
Development

No branches or pull requests

3 participants