Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] "Open In Firefox Preview" from Custom Tab doesn't open page #5025

Closed
agi90 opened this issue Aug 30, 2019 · 6 comments
Closed

[Bug] "Open In Firefox Preview" from Custom Tab doesn't open page #5025

agi90 opened this issue Aug 30, 2019 · 6 comments
Assignees
@ekager
Labels
🐞 bug Crashes, Something isn't working, .. E2 Estimation Point: easy, half a day to 2 days eng:qa:verified QA Verified Feature:CustomTabs P2 Upcoming release S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Milestone
v2.0

Comments

@agi90
Copy link
Contributor

agi90 commented Aug 30, 2019 •
edited by data-sync-user

Steps to reproduce

  • Open link in Custom Tab (e.g. from Twitter App)
  • Tap "Open in Firefox Preview"

Expected behavior

  • Page opens in Fenix

Actual behavior

  • Page flashes and then previous page opened appears

Device information

  • Android device: Samsung S10
  • Fenix version: Latest nightly from Play Store

┆Issue is synchronized with this Jira Task
@agi90 agi90 added the 🐞 bug Crashes, Something isn't working, .. label Aug 30, 2019
@pwd-github
Copy link

Just came to report this. This is incredibly annoying, but I have observed that the tab opens and then immediately closes when Fenix is left on the tab overview. Otherwise it just shows a previous tab.

@AndiAJ AndiAJ added the S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist label Sep 2, 2019
@AndiAJ
Copy link
Collaborator

AndiAJ commented Sep 2, 2019

Hi, reproducible on:
• 2.0.0-rc.1
• Nightly Build #12441810

Using the following devices:
• Google Pixel 3a (Android 9)
• Samsung Tab A (Android 9)

►Video
20190902_1302431

@vesta0 vesta0 added the P2 Upcoming release label Sep 3, 2019
@vesta0 vesta0 added this to To be Triaged in Fenix Sprint Kanban via automation Sep 3, 2019
@vesta0 vesta0 moved this from To be Triaged to Prioritized Bug Backlog in Fenix Sprint Kanban Sep 4, 2019
@ekager ekager self-assigned this Sep 4, 2019
@ekager ekager moved this from Prioritized Bug Backlog to In Progress in Fenix Sprint Kanban Sep 4, 2019
ekager added a commit to ekager/fenix that referenced this issue Sep 4, 2019
@ekager
For mozilla-mobile#5025 - Do not remove custom tab session with confi…
2beccfa 
…g removed
pocmo pushed a commit that referenced this issue Sep 5, 2019
@ekager @pocmo
For #5025 - Do not remove custom tab session with config removed
a5e9da7
@ekager ekager added eng:qa:needed QA Needed E2 Estimation Point: easy, half a day to 2 days labels Sep 5, 2019
@AndiAJ AndiAJ removed the eng:qa:needed QA Needed label Sep 9, 2019
@AndiAJ
Copy link
Collaborator

AndiAJ commented Sep 9, 2019

Hi @ekager , I've checked and the webpage is opened in Fenix.
On the other hand, the link from the custom tab doesn't populate the URL bar from Fenix.

I've used the latest Nightly Build #12520610 from 9/9 with the following devices:
• Google Pixel 3a (Android 9)
• Huawei Mate 20 Lite (Andriod 8.1.0)
• Samsung Galaxy S7 (Android 7)
• OnePlus A3 (Android 6.0.1)

►Video
20190909_124326

@pocmo pocmo mentioned this issue Sep 9, 2019
Closed
@pocmo
Copy link
Contributor

pocmo commented Sep 9, 2019

Thank you, @AndiAJ, this looks like an important bug - although I think unrelated to this bug fixed here. I can reproduce this in Reference Browser and assume that this is related to our feature-toolbar refactoring that has happened just recently. I filed the following AC issue to track that:
mozilla-mobile/android-components#4348

@ekager
Copy link
Contributor

ekager commented Sep 9, 2019

Closing this bug because unrelated to #5169

@ekager ekager closed this as completed Sep 9, 2019
Fenix Sprint Kanban automation moved this from In Progress to Done Sep 9, 2019
@ekager ekager mentioned this issue Sep 9, 2019
Closed
colintheshots pushed a commit that referenced this issue Sep 9, 2019
@ekager @colintheshots
For #5025 - Do not remove custom tab session with config removed
0e55506
@sv-ohorvath
Copy link
Contributor

Verified as fixed on RC 1.4.1
Devices:
Samsung Galaxy J7(Android 6)
Pixel (Android Q)
Samsung Galaxy Tab A (Android 9)

@jyeontaek jyeontaek added the eng:qa:verified QA Verified label Sep 12, 2019
@jyeontaek jyeontaek added this to the v2.0 milestone Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ekager ekager

Labels
🐞 bug Crashes, Something isn't working, .. E2 Estimation Point: easy, half a day to 2 days eng:qa:verified QA Verified Feature:CustomTabs P2 Upcoming release S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
9 participants
@pocmo @pwd-github @NotWoods @sv-ohorvath @agi90 @jyeontaek @ekager @vesta0 @AndiAJ