Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] about:config isn't enabled in Fenix nightly #5529

Closed
jamienicol opened this issue Sep 24, 2019 · 3 comments
Closed

[Bug] about:config isn't enabled in Fenix nightly #5529

jamienicol opened this issue Sep 24, 2019 · 3 comments
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified
Milestone
v2.1

Comments

@jamienicol
Copy link

jamienicol commented Sep 24, 2019 •
edited by data-sync-user

Steps to reproduce

Navigate to about:config

Expected behavior

the about:config page opens

Actual behavior

Error message: cannot complete request

Device information

  • Android device: Pixel 2, android 10
  • Fenix version: "Nightly 190924 12:53" (Build #12671259)
    📦: 14.0.0, 186fa2396
    🦎: 71.0a1-20190923094800

┆Issue is synchronized with this Jira Task
@jamienicol jamienicol added the 🐞 bug Crashes, Something isn't working, .. label Sep 24, 2019
@pocmo
Copy link
Contributor

pocmo commented Sep 24, 2019

about:config needs to be explicitly enabled in GeckoView now:
https://mozilla.github.io/geckoview/javadoc/mozilla-central/org/mozilla/geckoview/doc-files/CHANGELOG

Added GeckoRuntimeSettings.Builder#aboutConfigEnabled to control whether or not about:config should be available. (bug 1540065)

https://bugzilla.mozilla.org/show_bug.cgi?id=1540065

@hkaancaliskan
Copy link

@pocmo but it should be enabled for nightly builds, right?

agi90 pushed a commit to agi90/fenix that referenced this issue Sep 25, 2019
@agi
For mozilla-mobile#5529: Enable about:config in geckoNightly.
d7be30d
ekager pushed a commit that referenced this issue Sep 25, 2019
@agi @ekager
For #5529: Enable about:config in geckoNightly.
365936b
@ekager ekager added the eng:qa:needed QA Needed label Sep 26, 2019
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 27, 2019
@AndiAJ
Copy link
Collaborator

AndiAJ commented Sep 27, 2019

Hi, verified as fixed on Nightly Build #12700627 from 27/9 using the following devices:
• Google Pixel 3a (Android 9)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S7 (Android 7)
• OnePlus A3 (Android 6.0.1)
• LG Nexus 4 (Android 5.1.1)

► Pic
rsz_screenshot_20190927-105710

@AndiAJ AndiAJ closed this as completed Sep 27, 2019
@sblatz sblatz added this to the v2.1 milestone Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified
Projects
None yet
Milestone
v2.1
Development

No branches or pull requests
6 participants
@pocmo @jamienicol @sblatz @hkaancaliskan @ekager @AndiAJ