Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] about:config isn't enabled in Fenix nightly #5529

Closed
jamienicol opened this issue Sep 24, 2019 · 3 comments
Closed

[Bug] about:config isn't enabled in Fenix nightly #5529

jamienicol opened this issue Sep 24, 2019 · 3 comments

Comments

@jamienicol
Copy link

@jamienicol jamienicol commented Sep 24, 2019

Steps to reproduce

Navigate to about:config

Expected behavior

the about:config page opens

Actual behavior

Error message: cannot complete request

Device information

  • Android device: Pixel 2, android 10
  • Fenix version: "Nightly 190924 12:53" (Build #12671259)
    📦: 14.0.0, 186fa2396
    🦎: 71.0a1-20190923094800
@jamienicol jamienicol added the 🐞 bug label Sep 24, 2019
@pocmo

This comment has been minimized.

Copy link
Contributor

@pocmo pocmo commented Sep 24, 2019

about:config needs to be explicitly enabled in GeckoView now:
https://mozilla.github.io/geckoview/javadoc/mozilla-central/org/mozilla/geckoview/doc-files/CHANGELOG

Added GeckoRuntimeSettings.Builder#aboutConfigEnabled to control whether or not about:config should be available. (bug 1540065)

https://bugzilla.mozilla.org/show_bug.cgi?id=1540065

@hakkikaancaliskan

This comment has been minimized.

Copy link
Contributor

@hakkikaancaliskan hakkikaancaliskan commented Sep 24, 2019

@pocmo but it should be enabled for nightly builds, right?

agi90 added a commit to agi90/fenix that referenced this issue Sep 25, 2019
ekager added a commit that referenced this issue Sep 25, 2019
@AndiAJ

This comment has been minimized.

Copy link
Collaborator

@AndiAJ AndiAJ commented Sep 27, 2019

Hi, verified as fixed on Nightly Build #12700627 from 27/9 using the following devices:
• Google Pixel 3a (Android 9)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S7 (Android 7)
• OnePlus A3 (Android 6.0.1)
• LG Nexus 4 (Android 5.1.1)

► Pic
rsz_screenshot_20190927-105710

@AndiAJ AndiAJ closed this Sep 27, 2019
@sblatz sblatz added this to the v2.1 milestone Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.