-
Notifications
You must be signed in to change notification settings - Fork 1.3k
DL fails if "Download" folder is missing #5829
Comments
I understand that my #13134 is a duplicate and has been closed because of it, but it was far more detailed. Is there a way to bring that description of the bug here? And why is it taking so long to fix such a small issue? I really wanna use Firefox as I love the new design but I'm stuck using other browsers because of this. I tried it on Nightly 200905 06:01 today and the issue is still intact. Video of the issue - https://i.imgur.com/rWRM7dx.mp4 |
Sorry about the delay, we are a small team. we will try to pick the issue as soon as we have some availability. If you are willing to contribute the patch I will glad to help you :) |
Hey, I am sorry I came out as so entitled earlier. I would love to contribute a patch. Could you please point me in the right direction? I have never made Android apps, but I am good at Java. |
Would this issue be elligible for the good first issue tag? It seems like a fix for this wouldn't require deep understanding of the codebase. |
Do not worry :), we have some docs that can help you to get started. Fenix is the UI of multiple underneath projects Mozilla Android Components (AC) and GeckoView (GV). The bug is on the feature-downloads component on AC. I think specifically here, where we start to writing to disk and have to check if the folder is there if not we should create it. These docs can help you: If you need any additional help just let me know :) |
I agree it could be tagged as good first issue :) |
I tried a lot, but I am not able to build fenix when using I am able to build and run fenix without I don't think I'll be able to do this 😞 |
Is there any specific error that you are encountering? Here you can find a more detail guide of how auto-publication works that may bring some lights, another alternative is to publish manually your Android Component version to Maven Local and set your local Fenix to use it as a dependency. |
This is what I did:
Attachments: Download_and_Build.bat
|
@parvinderandroid sorry for no replying before, it's been a bumping week for me. I will try to take a look today, I'm not that familiar with dependency substitution (I normally use maven local that could be an alternative), I will ask to other team members on our chat channel on #fenix:mozilla.org channe and #android-components:mozilla.org, please feel free to join the conversation. |
The space in the android-components folder seems like a possible problem. The line where that is shown is |
Thank you so much. This might just do it. I am gonna try it as soon as I can.
No problems at all. I have been a little busy too. I am actually in the final year of my CS degree and have a lot of work to do. |
Hey. So I removed the space and tried doing the same steps, the only difference being that I tried it in Windows Sandbox this time. It still failed. I am attaching the Output on Screen and the Batch File Log: |
This was addressed on mozilla-mobile/android-components#8785 it should be fixed in the next nightly version. |
Sorry @parvinderandroid for taking this issue for you, but I had to addressed as the issue was most severe than I initially thought |
QA could you help us to confirm if this issue is fixed on nightly. Thanks in advance! |
Hey no problem. This is awesome. What more could I possibly want? |
I just checked and it's definitely fixed. Thank you so much, you guys are awesome! Proof - https://i.imgur.com/pphDeFD.mp4 |
Trying to download a file will fail if destination directory is deleted, maybe FF should just create a folder if needed, or inform the user why downloading cannot proceed.
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: