Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Settings default Theme says "Follow device theme" instead of "Light" on API 28 #6053

Closed
rpappalax opened this issue Oct 16, 2019 · 1 comment
Closed

[Bug] Settings default Theme says "Follow device theme" instead of "Light" on API 28 #6053

rpappalax opened this issue Oct 16, 2019 · 1 comment
Labels
🐞 bug Crashes, Something isn't working, ..

Comments

@rpappalax
Copy link
Contributor

rpappalax commented Oct 16, 2019 •
edited by data-sync-user

Steps to reproduce

Open 3 dot main menu
Open Settings
View chosen theme beneath "Theme" header
image

Expected behavior

Should indicate "Light" by default

Actual behavior

Says "Follow device theme" on API 28
image

Device information

  • Android device: ?
  • Fenix version: ?

┆Issue is synchronized with this Jira Task
@rpappalax rpappalax added the 🐞 bug Crashes, Something isn't working, .. label Oct 16, 2019
@rpappalax rpappalax mentioned this issue Oct 16, 2019
Merged
5 tasks
@rpappalax rpappalax changed the title [Bug] Settings Theme says "Follow device theme" instead of "Light" on API 28 [Bug] Settings default Theme says "Follow device theme" instead of "Light" on API 28 Oct 17, 2019
@rpappalax
Copy link
Contributor Author

Per @colintheshots this is by design so closing.

some notes for reference:
This is a new feature of later versions of Android. It's deliberate.
There's three settings, not two.
We just hide that OS default on versions that don't offer it,
It's different because we cannot support it on older versions.
it's there because we don't yet know what they want, but their OS tells us what colors it is using.
It'll change theme by time of day or when connected to Android Auto in some cases
In Android 10, the user can enable Force Dark in OS settings and it'll stay Dark theme in that mode

bors bot pushed a commit that referenced this issue Oct 21, 2019
@MozLando @rpappalax
Merge #6059
fed0c88 
6059: Add verify items tests for settings menus r=kglazko a=rpappalax

Also closes #6006

All UI tests are passing with the exception of 1 which was just uncovered by a new test in this PR.  Issue here:
#6053



Co-authored-by: Richard Pappalardo <rpappalax@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Crashes, Something isn't working, ..
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rpappalax