Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Dismissing QAB by tapping the pill in middle taps the action as well #6154

Closed
bogas04-swiggy opened this issue Oct 21, 2019 · 4 comments
Labels
🐞 bug Crashes, Something isn't working, ..

Comments

@bogas04-swiggy
Copy link

bogas04-swiggy commented Oct 21, 2019

Steps to reproduce

  1. Open Quick Action Bar by tapping the middle pill
  2. Dismiss it by tapping the pill again

Expected behavior

Should dismiss normally

Actual behavior

Dismisses as well as taps the action (bookmark or share)

Screencast

Device information

  • Android device: RealmeX, Android 9, ColorOS
  • Fenix version: Nightly 191020 18:01 (Build #12931810) 📦: 18.0.0, d40f5a40d 🦎: 71.0a1-20191018095340

┆Issue is synchronized with this Jira Task

@bogas04-swiggy bogas04-swiggy added the 🐞 bug Crashes, Something isn't working, .. label Oct 21, 2019
@BranescuMihai
Copy link
Contributor

Our QuickActionSheet looks like is designed as a Modal BottomSheet, and the material design guidelines suggest that we should not collapse the modal on tap. Maybe UX can confirm this.
Resources:
Go to control section for the modal bottom sheet
Merged pull request from flutter removing this exact functionality to be in line with material design

@BranescuMihai BranescuMihai added the needs:UX-feedback Needs UX Feedback label Oct 25, 2019
@brampitoyo
Copy link

@BranescuMihai is correct:

…the material design guidelines suggest that we should not collapse the modal on tap

Specifically, the modal should not close when the pill is tapped.

Instead, what should happen is… nothing. In the demo video you posted, @bogas04-swiggy, you clearly didn’t tap on Bookmarks. So the Bookmarks page shouldn’t show up, either.

Only when you tap the area outside of the modal, then it will close.

@brampitoyo
Copy link

I would say that this issue is WONTFIX. What does need to be fixed is the fact that tapping the pill shouldn’t tap any other button in the Quick Action Bar.

@brampitoyo brampitoyo removed the needs:UX-feedback Needs UX Feedback label Oct 31, 2019
@ekager
Copy link
Contributor

ekager commented Nov 14, 2019

Closing because we removed the QAB

@ekager ekager closed this as completed Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, ..
Projects
None yet
Development

No branches or pull requests

4 participants