Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new search partner #6480

Open
mkaply opened this issue Nov 6, 2019 · 8 comments

Comments

@mkaply
Copy link

@mkaply mkaply commented Nov 6, 2019

We're adding a new search partner to Fenix, Ecosia.

The search URL is:

https://www.ecosia.org/search?q={searchTerms}&tt=813cf1dd

This will be for Germany (de) only.

@st3fan

This comment has been minimized.

Copy link
Contributor

@st3fan st3fan commented Nov 7, 2019

@pocmo the list of search partners + codes lives in A-C right?

@pocmo

This comment has been minimized.

Copy link
Contributor

@pocmo pocmo commented Nov 8, 2019

@mkaply Was that change made in mozilla-central/mobile/ too? Then we could just re-import that into AC.

Otherwise we can update list.json and the plugins in AC:

@mkaply Would you want to create a PR for that in AC? You know those files the best.. :)

@mkaply

This comment has been minimized.

Copy link
Author

@mkaply mkaply commented Nov 8, 2019

No, this was a specific change for just Fenix. I'll create a patch.

@veyselerden

This comment has been minimized.

Copy link

@veyselerden veyselerden commented Nov 12, 2019

Why just Germany? I am not in Germany but want to use Ecosia with Fenix, not Ecosia app on Android which is based on Chromium.

@pocmo

This comment has been minimized.

Copy link
Contributor

@pocmo pocmo commented Nov 12, 2019

No, this was a specific change for just Fenix.

Alright. In this case we could still consider landing the search plugin in AC. Focus and Fire TV have custom code to mix in and filter search engines. This should also work for adding this search engine dynamically.

@cadeyrn

This comment has been minimized.

Copy link
Contributor

@cadeyrn cadeyrn commented Nov 20, 2019

Why just Germany? I am not in Germany but want to use Ecosia with Fenix, not Ecosia app on Android which is based on Chromium.

Since #6551 Ecosia is shipped as optional search engine and you can manually enable it. And even if not, since #6551 you can also add custom search engines.

@bifleming bifleming added the needs:ac label Nov 21, 2019
@liuche

This comment has been minimized.

Copy link
Member

@liuche liuche commented Nov 25, 2019

@mkaply are you handling this? incl writing tests, etc.

@mkaply

This comment has been minimized.

Copy link
Author

@mkaply mkaply commented Nov 26, 2019

It's being done here: in android components and then we can put it in Fenix

mozilla-mobile/android-components#5059

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
You can’t perform that action at this time.