Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Telemetry] Default top sites #8125

Closed
vesta0 opened this issue Feb 5, 2020 · 11 comments
Closed

[Telemetry] Default top sites #8125

vesta0 opened this issue Feb 5, 2020 · 11 comments
Assignees
Labels
E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified Feature:Shortcuts Top Sites/Topsites on the Firefox home page Feature:Telemetry

Comments

@vesta0
Copy link
Collaborator

vesta0 commented Feb 5, 2020

Description & Product Manager / Data Scientist User Story

  • As a product owner, I want to know if users find default top sites useful.

What questions will you answer with this data?

  • How often users interact with default top sites?
  • How often users tap on pocket stories?

What probes (suggested, if applicable)

  • User taps on any default top site (not tracking URLs)
  • User taps on pocket stories icon

Acceptance Criteria (Added by PM)

  • Event pings can be queried via re:dash
  • We are sending telemetry events for the actions listed in the requirements
  • We have documented the telemetry
  • We have asked a data steward to review the telemetry
  • NOT an AC: Data science to create dashboard or further graphs (this will be a separate issue, this issue is only about hooking up the events described and that they can be queried in re-dash)

┆Issue is synchronized with this Jira Task

@vesta0 vesta0 added Feature:Telemetry Feature:Shortcuts Top Sites/Topsites on the Firefox home page should labels Feb 5, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 5, 2020
@vesta0 vesta0 mentioned this issue Feb 5, 2020
15 tasks
@ekager ekager self-assigned this Feb 18, 2020
@ecsmyth
Copy link

ecsmyth commented Feb 27, 2020

The performance team would like request that the probes for add/remove a top site include an extra key with the number of top sites that users have.

@vesta0
Copy link
Collaborator Author

vesta0 commented Feb 27, 2020

@ecsmyth I assume you are looking to see if there is correlation between page load speed and total number of top sites?

@ekager
Copy link
Contributor

ekager commented Feb 27, 2020

And @ecsmyth I'm assuming this is for any top site (not just the defaults)

@ecsmyth
Copy link

ecsmyth commented Feb 27, 2020

@vesta0 we've seen a correlation between startup time and the number of top sites in local testing. We're working on a possible fix for 4.0, however, knowing quantities will better inform both technical and UX-based solutions.

@ekager, yes, for any top site.

@gabrielluong
Copy link
Member

I am wondering if we should do a metrics ping instead of adding the extra key to the existing add/remove top sites. Metrics ping would send a ping once a day and can report the number of top sites for an user.

@ecsmyth
Copy link

ecsmyth commented Feb 27, 2020

@gabrielluong, nod. That would make time-series analysis easier.

@liuche
Copy link
Contributor

liuche commented Mar 24, 2020

@ekager if you have time this week or next, could you wrap this up? This sounds like something that has been on the perf team's radar for a while.

@ekager
Copy link
Contributor

ekager commented Mar 24, 2020

Yep for the non defaults I can add what @ecsmyth was describing. For the defaults @gabrielluong and I are working on #9286 which will make default telemetry much easier.

@liuche liuche mentioned this issue Apr 28, 2020
32 tasks
@sblatz sblatz assigned sblatz and unassigned ekager May 15, 2020
sblatz added a commit to sblatz/fenix that referenced this issue May 18, 2020
sblatz added a commit to sblatz/fenix that referenced this issue May 18, 2020
sblatz added a commit to sblatz/fenix that referenced this issue May 19, 2020
sblatz added a commit to sblatz/fenix that referenced this issue May 22, 2020
sblatz added a commit to sblatz/fenix that referenced this issue May 22, 2020
sblatz added a commit to sblatz/fenix that referenced this issue May 22, 2020
sblatz added a commit to sblatz/fenix that referenced this issue May 22, 2020
sblatz added a commit to sblatz/fenix that referenced this issue May 22, 2020
@sblatz sblatz added the eng:qa:needed QA Needed label May 22, 2020
@liuche liuche added the E3 Estimation Point: average, 2 - 3 days label May 22, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented May 29, 2020

Hi, verified as fixed on the latest Nightly Build 200529 from 5/29 using a Google Pixel 3a (Android 10)

Open the top sites

✔️ Youtube - Ping a6e51160-7b69-465b-be3c-aa874006b10e

      "events": [
        {
          "category": "top_sites",
          "name": "open_in_new_tab",
          "timestamp": 0
        },
        {
          "category": "top_sites",
          "name": "open_default",
          "timestamp": 1
        }
      ]

✔️ Wikipedia - Ping 392dc64b-731e-48ae-af70-e02136613b1e

"events": [
        {
          "category": "top_sites",
          "name": "open_in_new_tab",
          "timestamp": 0
        },
        {
          "category": "top_sites",
          "name": "open_default",
          "timestamp": 0
        }
      ]

✔️ Pocket - Ping da6c404e-ccae-4888-92eb-9ebe9394d723

"events": [
{
"category": "top_sites",
"name": "open_in_new_tab",
"timestamp": 0
},
{
"category": "top_sites",
"name": "open_default",
"timestamp": 0
},
{
"category": "pocket",
"name": "pocket_top_site_clicked",
"timestamp": 1
}

Remove 2 out of the 3 default top sites

✔️Wikipedia & Pocket - Ping ccfc3415-aebe-4739-8b4d-d02415b059b6

"events": [
        {
          "category": "top_sites",
          "name": "remove",
          "timestamp": 0
        },
        {
          "category": "pocket",
          "name": "pocket_top_site_removed",
          "timestamp": 2
        },
        {
          "category": "top_sites",
          "name": "remove",
          "timestamp": 5103
        }

Metrics ping

✔️ Number of top sites that users have. - Ping f5ee135b-7792-4426-8033-25b5aea9a4a1

"metrics.top_sites_count": 1

Log
Glean dashboard

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified Feature:Shortcuts Top Sites/Topsites on the Firefox home page Feature:Telemetry
Projects
None yet
Development

No branches or pull requests

7 participants