Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta] Bookmarks (formerly Favourites) #90

Closed
bbinto opened this issue Dec 3, 2018 · 9 comments
Closed

[Meta] Bookmarks (formerly Favourites) #90

bbinto opened this issue Dec 3, 2018 · 9 comments

Comments

@bbinto
Copy link
Contributor

@bbinto bbinto commented Dec 3, 2018

Favourite != bookmark and won't provide bookmark management
Will be stored locally in your library, will show up in history, recency

Update Feb 22: We've agreed that we revert back to using Favourites as bookmarks.

User story:

As a user, I want to be able to bookmark a site, view it, remove it, share it, and sync it with my other devices, so I can save time finding information I need, stay organized, and have a seamless experience switching between my devices.

Dependencies:

A-C (done)
Currently blocked by: mozilla/application-services#880

@bbinto bbinto added this to the Fenix 1.0 milestone Dec 3, 2018
@bbinto bbinto changed the title Save website as favourite Quick action menu: Save website as favourite Dec 3, 2018
@Sdaswani Sdaswani changed the title Quick action menu: Save website as favourite [meta] Quick action menu: Save website as favourite Dec 6, 2018
@Sdaswani Sdaswani modified the milestones: Fenix V1.0, MVP Metas Jan 18, 2019
@bbinto bbinto changed the title [meta] Quick action menu: Save website as favourite [meta] Save website as favourite Jan 22, 2019
@bbinto bbinto added the Epic label Jan 22, 2019
@davismtl
Copy link

@davismtl davismtl commented Jan 23, 2019

@bbinto I'm trying to get some clarification for myself, my team and some members of leadership who have asked me about bookmarks and bookmark syncing.

Would it be possible to get details on how favorites and bookmarks are different? User stories and or success criteria would be nice here if possible.

It is my hope to help you achieve your goals here.

For reference, here are some questions I've been asked:

  • Will Fenix have bookmarks? If so, when?
  • Will Fenix Sync bookmarks? If so, when?
  • What's the difference between bookmarks and favorites? (asked above)
  • Are favorites just a flat structure of bookmarks?
  • Are favorites just a stop-gap until there is a bookmarks component with full management?
  • If favorites are different than bookmarks, should they be synced?
    • If they are synced, how should they be displayed on desktop and how do we differentiate them from bookmarks?

Thanks in advance for looking into this.

CC @ryanfeeley

@bbinto bbinto added this to Unassigned in Fenix MVP Jan 25, 2019
@bbinto bbinto modified the milestone: MVP Metas Jan 25, 2019
@bbinto bbinto moved this from Unassigned to Milestone 5 in Fenix MVP Jan 30, 2019
@bbinto bbinto added the must label Jan 30, 2019
@ryanfeeley
Copy link

@ryanfeeley ryanfeeley commented Feb 5, 2019

@bbinto Would love to hear more about this. It's very difficult to argue that favourites do not equal bookmarks when bookmarks are called favourites in Internet Explorer. I wholly support Fenix doing something different with the interface to present and manage bookmarks, but creating a datatype outside of the ecosystem without a clear plan is a form of cannibalization.

@bbinto
Copy link
Contributor Author

@bbinto bbinto commented Feb 6, 2019

@ryanfeeley I agree and talked to UX (@topotropic and @shorlander)

Finally replying here (although I've already caught up with Alex offline)

Will Fenix have bookmarks? If so, when?

Yes, for MVP

Will Fenix Sync bookmarks? If so, when?

Yes, ideally for MVP

What's the difference between bookmarks and favorites? (asked above)

@shorlander should add more color here as he will be providing more details on that, however overall, we want to treat them similar than bookmarks from the data structure / syncing aspect. They might be shown different UI, i.e. in a flat structure

Are favorites just a flat structure of bookmarks?

see above

Are favorites just a stop-gap until there is a bookmarks component with full management?

No

If they are synced, how should they be displayed on desktop and how do we differentiate them from bookmarks?

@shorlander and @topotropic to provide their input.

Unless there is a really strong case from UX (I would need to be convinced with data :)
), I would like to go with the simplest way / feature parity to Fennec where possible, this will make the transition from Fennec sync to Fenix sync easier.

@yoasif
Copy link
Contributor

@yoasif yoasif commented Feb 7, 2019

@bbinto This is very confusing to picture, I read this a couple of times, and the most I was initially able to make out is that "favorites" is like "Top Sites" in Fennec and Firefox Desktop, except that they might be presented as a list instead of tiles -- and that they would be saved in bookmarks somehow (and so would appear on synced devices, unlike top sites).

Are favorites just a stop-gap until there is a bookmarks component with full management?

No

This is worrisome though, since it sounds as if "Favorites" replace bookmarks somehow (flattening them?) and so I don't quite understand how that reaches feature parity with Fennec, since:

  • Fennec allows the creation of folders (including within the root "Mobile Bookmarks" directory)
  • synced data from Desktop Firefox will always have folders
  • bookmarks can be moved from folder to folder, across desktop or mobile (even from within Fennec)

On Fennec, while users cannot choose where to create bookmarks initially (bookmarks always save to the root "Mobile Bookmarks" directory by default), they are able to move them anywhere, like a folder within "Mobile Bookmarks", or even into "Desktop Bookmarks" folders.

This is available in either the bookmarks list or in the edit UI that appears after a user clicks "options" in the snackbar that appears after they bookmark an item.

I have seen comments where users are confused as to why there is such a strict separation between Mobile and Desktop bookmarks, example:

And why the hell there are two groups of bookmarks? One says mobile and other says my Ubuntu OS? If I am the same person then why categorise bookmarks between phone and PC?

Response

You just cannot choose where to put bookmarks on mobile. Mobile can view properly organised bookmarks from desktop no problem. :/

I launched Chrome and realized why. While Chrome defaults users to "Mobile Bookmarks" like Fennec, unlike Fennec, it remembers the last place the user created a bookmark and saves it there, without the dance of "options > edit > move".

So users can actually ignore the root "Mobile Bookmarks" directory on Chrome entirely, saving to a folder within it, or when Sync is enabled, saving directly into "desktop" bookmark folders.

It feels very intuitive and I think it belongs in Fenix.

Bookmark discovery in Chrome is worse than in Fennec though - it is hidden behind a hamburger menu, whereas about:home has a nice tab for it. What is handy though, is that the bookmarks UI in Chrome remembers the last place you were, which would be another nice improvement to bring to about:home in Fenix (is that planned?) so that users don't need to drill into desktop bookmarks if they are defaulting their bookmark creation to a non root Mobile Bookmarks folder.

I took a screen recording of the process to create bookmarks in non default (and flat) hierarchies in Fennec - it isn't very convenient, but it is possible (it is nicer in Chrome).

https://drive.google.com/open?id=1w1gpRAAiQ3UIS41U5BDbEAnpDr_FhL6W

@cadeyrn
Copy link
Contributor

@cadeyrn cadeyrn commented Feb 7, 2019

This is worrisome though

I agree. Bookmarks are one of the most important features of any browser, especially on a smartphone where typing URLs is such an annoying thing. And because bookmarks are so important, the ability to organize them is important, too. With only five bookmarks you won't need folders. But with many bookmarks it's not easy to find your bookmarks if you don't have any structure. In my opinion a flat hierarchy is really not sufficient for bookmarks.

The bookmarks management in Fennec is not perfect. But it's good enough for a first version. To lose this feature would be a huge regression IMO.

@davismtl
Copy link

@davismtl davismtl commented Feb 7, 2019

I'll try to shed some light here.
@bbinto mentioned:

Will Fenix have bookmarks? If so, when?

Yes, for MVP

Will Fenix Sync bookmarks? If so, when?

Yes, ideally for MVP

Ultimately, Fenix will have bookmarks and they will sync to desktop and other devices. The Application Services team has already been working on the Rust component for Bookmark storage and syncing. The component will be designed to provide Fenix with bookmark management that will be at parity with desktop. (i.e. full management with ability to create folders, rename, etc) It will just be a matter of surfacing UI to do it.

Everything can be summarized by the answers of these two questions:

  • Will users expect to find their desktop bookmarks on Fenix? We believe the answer is yes.
  • Will Fenix users expect to find their bookmarks/favorites on Desktop? We also believe the answer to be yes.

In terms of UI/UX changes... @bbinto said:

I would like to go with the simplest way / feature parity to Fennec where possible, this will make the transition from Fennec sync to Fenix sync easier.

This all being said, the initial post in this issue is inaccurate now based on Barbara's most recent comment (and my offline conversation with her):

Favourite != bookmark and won't provide bookmark management

As a side note, bookmarks have a concept of labels which aren't widely used by users but are in the data model. In the future, we can explore and experiment with a new UI or various ways of sorting bookmarks. This should allow us to explore the types of experiences that Barbara initially had in mind while maintaining compatibility with other browsers.

@bbinto bbinto changed the title [meta] Save website as favourite [Meta] Save website as favourite Feb 13, 2019
@bbinto bbinto moved this from Milestone 5 (Q2) FINAL to Milestone 3 (End of Q1) in Fenix MVP Feb 13, 2019
@bbinto bbinto added this to Fenix Integration in A-C: Meta: Sync Bookmarks Feb 13, 2019
@bbinto bbinto changed the title [Meta] Save website as favourite [Meta] Favourites Feb 13, 2019
@bbinto
Copy link
Contributor Author

@bbinto bbinto commented Feb 22, 2019

Thanks everyone (@yoasif @cadeyrn etc), I've updated my original comment and confirm that we will provide bookmark like functionality with the goal to have them also synced for MVP (should) (mozilla-mobile/android-components#1851)

@bbinto bbinto changed the title [Meta] Favourites [Meta] Bookmarks (formerly Favourites) Mar 1, 2019
@bbinto bbinto self-assigned this Mar 4, 2019
@mheubusch
Copy link
Contributor

@mheubusch mheubusch commented Apr 25, 2019

Engineering - please review the items on this spreadsheet - this is a punchlist showing fit and finish issues blocking feature completeness.
https://docs.google.com/spreadsheets/d/1te0ap-CE9tzZGvdPRmYBB5aWTW3L5gZLZhxA8tG5tgM/edit?usp=sharing

@bbinto bbinto removed their assignment May 6, 2019
@vesta0
Copy link
Member

@vesta0 vesta0 commented Jul 5, 2019

The work for MVP is completed.

@vesta0 vesta0 closed this Jul 5, 2019
A-C: Meta: Sync Bookmarks automation moved this from Fenix Integration to Done Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Fenix MVP
Milestone 3 (End of Q1)
Linked pull requests

Successfully merging a pull request may close this issue.

None yet