Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta] Share Intent System #92

Closed
bbinto opened this issue Dec 3, 2018 · 6 comments

Comments

@bbinto
Copy link
Contributor

commented Dec 3, 2018

Why/User Benefit/User Problem

Share tool: Share information on the web

  • As a user, I want to share information I find on the web with myself so that I can retrieve it later
  • As a user, I want to share information I find on the web with others so they can access it

What / Requirements

  • I don’t need to sign up for an account
  • Reinforce and support through existing sharing behaviours (e.g. email)
  • The share function (e.g., button) must be in a color that has high contrast with its background.
  • The share function must have an accessible label.

Acceptance Criteria (how do I know when I’m done?)

Phase 1: Android default intent share integration

@bbinto bbinto added this to the Fenix 1.0 milestone Dec 3, 2018
@Sdaswani Sdaswani changed the title Quick action menu: Send and Share [meta] Quick action menu: Send and Share Dec 6, 2018
@Sdaswani Sdaswani modified the milestones: Fenix V1.0, MVP Metas Jan 18, 2019
@bbinto bbinto changed the title [meta] Quick action menu: Send and Share [meta] Send and Share Jan 22, 2019
@bbinto bbinto added the Epic label Jan 22, 2019
@bbinto bbinto changed the title [meta] Send and Share [Meta] Send and Share Jan 22, 2019
@bbinto bbinto added this to Milestone 2 (Q1) in Fenix MVP Jan 22, 2019
@st3fan

This comment has been minimized.

Copy link
Contributor

commented Jan 23, 2019

The only sharing that is feasible for MVP is:

  • Standard Android Share Sheet to share the current page you are looking at (or the link you long press on)
  • "Send Tab" functionality to send a tab to one of your other devices (requires FxA)

The first is done and ready to be integrated - see the Reference Browser for guidance.

The latter is a stretch Q1 OKR for the A-C team and heavily depends on the work the App Services team is doing for this. Initial discussions to understand all the moving pieces and work to break it down has started.

@bbinto Regarding time - after talking to the App Services team today I think it will be safe to assume that Send Tab could be ready for testing early Q2. So that would be during Milestone 3. We will be working on a more comprehensive timeline for this work with the PushBox team.

@bbinto

This comment has been minimized.

Copy link
Contributor Author

commented Jan 24, 2019

I am aware that this might have to be scoped down, and I'm ok with it (i.e. only sharing tab/sessions via standard Android intent system (and send tab))

Maybe we should make this first about integrating with the intent system and next step, in a later milestone, focus on Send Tab integration?

@bbinto bbinto changed the title [Meta] Send and Share [Meta] Send and Share [Share Intent System] Jan 24, 2019
@bbinto bbinto added the meta size S label Jan 24, 2019
@shorlander

This comment has been minimized.

Copy link

commented Jan 25, 2019

I would like to discuss how we prioritize this because friction-less sharing of complete workflows is one of the key pillars of sessions.

@jdragojevic

This comment has been minimized.

Copy link

commented Feb 20, 2019

A-S team send-tab component high-level tracking.

@jonalmeida

This comment has been minimized.

Copy link
Member

commented Feb 20, 2019

Maybe we should make this first about integrating with the intent system and next step, in a later milestone, focus on Send Tab integration?

We have good integration with sharing tabs via Android intents already and we're currently working on send tab via FxA.

Along with the project board that Janet has linked to above, the A-C project board for send-tab is here: https://github.com/orgs/mozilla-mobile/projects/19

@vesta0 vesta0 removed the P1 label Mar 18, 2019
@vesta0 vesta0 closed this Apr 23, 2019
@mheubusch

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

Engineering - please review the items on this spreadsheet - this is a punchlist showing fit and finish issues blocking feature completeness.

https://docs.google.com/spreadsheets/d/14VQEpCQ9cbj2sFL0PR0oGdg09KFiqU2kPAl-Opt9m7w/edit?usp=sharing

@mheubusch mheubusch reopened this Apr 25, 2019
@mheubusch mheubusch added the eng:ready label Apr 25, 2019
@mheubusch mheubusch modified the milestones: MVP Metas, MVP Backlog Apr 25, 2019
@mheubusch mheubusch added this to the MVP Metas milestone Apr 25, 2019
@vesta0 vesta0 changed the title [Meta] Send and Share [Share Intent System] [Meta] Share Intent System May 17, 2019
@vesta0 vesta0 closed this May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Fenix MVP
Milestone 2 (Q1)
9 participants
You can’t perform that action at this time.