Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]Failed download after resuming it #9354

Closed
AndiAJ opened this issue Mar 24, 2020 · 29 comments
Closed

[Bug]Failed download after resuming it #9354

AndiAJ opened this issue Mar 24, 2020 · 29 comments
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Download S3 Blocks non-critical functionality and a work around exists wontfix

Comments

@AndiAJ
Copy link
Collaborator

AndiAJ commented Mar 24, 2020

Steps to reproduce

  1. Navigate to https://firefox-ci-tc.services.mozilla.com/api/index/v1/task/project.mobile.fenix.v2.nightly.latest/artifacts/public/build/armeabi-v7a/geckoNightly/target.apk and confirm the download.
  2. Pause the download
  3. Resume the download

Expected behavior

The download should be properly resumed.

Actual behavior

The download fails after resume.

Device information

  • Android device:
    • Google Pixel 3a (Android 10)
    • OnePlus A3 (Android 6.0.1)

  • Fenix version:
    • Nightly Build #20840606 from 3/24
    • Fenix Beta 4.2.0-beta.1 from 3/24

Notes

► Video
20200324-113304

┆Issue is synchronized with this Jira Task

@AndiAJ AndiAJ added 🐞 bug Crashes, Something isn't working, .. Feature:Download S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist labels Mar 24, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Mar 24, 2020
@st3fan st3fan added this to To do in Fenix: Downloads Mar 27, 2020
@st3fan st3fan moved this from To do to To Triage / Prioritize in Fenix: Downloads Mar 27, 2020
@liuche
Copy link
Contributor

liuche commented Mar 31, 2020

Related to #8930 ?

@Amejia481
Copy link
Contributor

Related to #8930 ?

I think it could be a different issue I added to the backlog of the download board

@Amejia481 Amejia481 moved this from To Triage / Prioritize to Backlog in Fenix: Downloads May 27, 2020
@lobontiumira
Copy link

I was able to reproduce this issue on the latest Nightly build from 10/9 (AC: 63.0.20201008190100, GV: 83.0a1-20201008094950) with HTC 10 (Android 8). I tried downloading a .zip file from https://www.thinkbroadband.com/download, paused and resumed the download in the notification, and the download failed.

@AndiAJ AndiAJ changed the title [Bug]Failed download after resuming an .apk download [Bug]Failed download after resuming it Oct 9, 2020
@AndiAJ
Copy link
Collaborator Author

AndiAJ commented Oct 22, 2020

Reproducible on Firefox Beta 83.0.0-beta.1 using a OnePlus A3 (Android 6.0.1) after resuming downloads on:

https://file-examples.com/
https://www.thinkbroadband.com/download

@Amejia481
Copy link
Contributor

This will be fixed when mozilla-mobile/android-components#8906 lands. There are some caveats that we have to keep in mind.

  • Resuming a download is not always possible as not all the web servers support that functionality, we are showing the pause/resume buttons on all downloads giving the false expectation that all downloads can be resumed, this is a bug and will be addressed on Only show pause/resume button for server that supports Accept-Ranges android-components#8903.

  • Not all intents of resuming a download will be successful, downloads that are behind authentication, normally will FAIL, we have some API limitation that doesn't allow to cover this use case.

@AndiAJ
Copy link
Collaborator Author

AndiAJ commented Nov 10, 2020

Hi @Amejia481 , still reproducible on Nightly Build 201110 using the following devices:
• Google Pixel 3a (Android 11)
• Huawei Mate 20 Lite (Android 10)
• OnePlus A3 (Android 6.0.1)

Pause/Resume still fails on the following websites:
https://file-examples.com/
https://firefox-ci-tc.services.mozilla.com/tasks/index/mobile.v2.fenix.nightly.latest/arm64-v8a
https://www.thinkbroadband.com/download

@Amejia481 Amejia481 moved this from ⏳ Review/QA to 🏃‍♀️ In Progress in A-C: Android Components Sprint Planning Nov 10, 2020
@Amejia481
Copy link
Contributor

Thanks @AndiAJ, I'm taking a look!

@Amejia481
Copy link
Contributor

@AndiAJ which ac version does is the build using?

@Amejia481 Amejia481 moved this from 🏃‍♀️ In Progress to ⏳ Review/QA in A-C: Android Components Sprint Planning Nov 10, 2020
@Amejia481
Copy link
Contributor

The fix is available on AC 66.0.20201109143146

@Mugurell Mugurell added the eng:qa:needed QA Needed label Nov 11, 2020
@sflorean
Copy link
Contributor

Verified as fixed on Nightly 11/11 - AC 66.0.20201109143146 with Pixel 3 (Android 11), and Samsung Note10 (Android 10).

@Amejia481
Copy link
Contributor

The fix should be available after #16800 lands it will contain a updated version of ac 68.0.20201201190117

@Amejia481 Amejia481 added the eng:qa:needed QA Needed label Dec 3, 2020
@Amejia481
Copy link
Contributor

I think ac 68.0.20201201190117 should be in nightly by now, we could retest

@AndiAJ
Copy link
Collaborator Author

AndiAJ commented Dec 4, 2020

Hi @Amejia481 , I've just re-checked this matter on the latest Nightly 201204 05:00 (Build #2015779369) AC:69.0.20201203202830, 99e23fce4 GV: 85.0a1-20201203094726 AS: 67.0.0 using a OnePlus A3 (Android 6.0.1) and it's still failing after resume.

Logcat

► Video
20201204-133415

@AndiAJ AndiAJ removed the eng:qa:needed QA Needed label Dec 4, 2020
@Amejia481
Copy link
Contributor

Hi @Amejia481 , I've just re-checked this matter on the latest Nightly 201204 05:00 (Build #2015779369) AC:69.0.20201203202830, 99e23fce4 GV: 85.0a1-20201203094726 AS: 67.0.0 using a OnePlus A3 (Android 6.0.1) and it's still failing after resume.

Logcat

► Video
20201204-133415

Thanks for the report, could you try to re-capture the logs, the previous one doesn't have downloads entries. I'm looking for this key AbstractFetchDownloadSeit gets logged every time we update the download notification, thanks in advance!

@AndiAJ
Copy link
Collaborator Author

AndiAJ commented Dec 4, 2020

Hi @Amejia481 , downloaded a couple of files and not sure why, but the key isn't displayed.

Used these devices:
• Google Pixel 3a (Android 11)
• OnePlus 6T (Android 9)
• OnePlus A3 (Android 6.0.1)

@Amejia481 Amejia481 moved this from ⏳ Review/QA to 🏃‍♀️ In Progress in A-C: Android Components Sprint Planning Dec 7, 2020
@Amejia481
Copy link
Contributor

@AndiAJ is this always reproducible reliably, after doing the same steps over and over ?

@Amejia481
Copy link
Contributor

When the failed download is shown, what happens after you click the "RETRY AGAIN" button? Does the download resume or it starts from the scratch?

@Amejia481 Amejia481 moved this from 🏃‍♀️ In Progress to ⏳ Sprint Backlog in A-C: Android Components Sprint Planning Dec 7, 2020
@AndiAJ
Copy link
Collaborator Author

AndiAJ commented Dec 8, 2020

Hi @Amejia481 , I've just re-checked this matter on 84.0.0-beta.4 using a OnePlus A3 (Android 6.0.1)

@AndiAJ is this always reproducible reliably, after doing the same steps over and over ?

Not always, sometimes it happens on the first attempt sometimes only after a couple of tries.

As previously mentioned it seems to be happening after you resume when the file is almost downloaded
For instance, it failed after resuming the download when the progress was at 94%

When the failed download is shown, what happens after you click the "RETRY AGAIN" button? Does the download resume or it starts from the scratch?

It failed again right away.
It looks like it wants to download an indexed the file.

E.g.

Action File Name
First fail 5MB.zip
Press "Try again" 5MB (1).zip
Press "Try again" 5MB (1) (1).zip
Press "Try again" 5MB (1) (1) (1).zip

@Amejia481
Copy link
Contributor

I will give it another try later in the week, I think we could decrease the priority to S3, due to this is not something that is always happening and affecting users constantly. Please feel free to change the priority back if needed.

@Amejia481 Amejia481 added S3 Blocks non-critical functionality and a work around exists and removed S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist labels Dec 8, 2020
@Amejia481 Amejia481 removed this from ⏳ Sprint Backlog in A-C: Android Components Sprint Planning Dec 14, 2020
@amedyne amedyne added the Beta Beta release bugs label Jan 28, 2021
@amedyne amedyne added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Feb 18, 2021
@Amejia481 Amejia481 moved this from Ready for Engineering (min-5 ; max-22) to In Development (WIP limit - 15) in Android Engineering Team Kanban board Feb 18, 2021
@Amejia481 Amejia481 removed this from In Development (WIP limit - 15) in Android Engineering Team Kanban board Feb 18, 2021
@amedyne amedyne removed the Beta Beta release bugs label Mar 1, 2021
@stale
Copy link

stale bot commented Aug 28, 2021

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 28, 2021
@mariansima
Copy link

This issue still occurs on Samsung A8 SM-A530F Android 9 Nightly 93.0a1 2021-08-30 with low chance of triggering (one out of three aproximately)

@stale stale bot removed the wontfix label Aug 30, 2021
@stale
Copy link

stale bot commented Feb 26, 2022

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 26, 2022
@SoftVision-LorandJanos
Copy link

SoftVision-LorandJanos commented Feb 28, 2022

This issue is no longer reproducible on the latest Nightly 99.0a1 (2022-02-28).
The download continues after resuming.
Device used: Oppo Reno 6 (Android 11).
Closing the ticket as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Download S3 Blocks non-critical functionality and a work around exists wontfix
Projects
No open projects
Fenix: Downloads
  
Backlog
Development

No branches or pull requests

9 participants