Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1516: fixed scrolling library menu in landscape mode #1544

Merged
merged 1 commit into from Apr 11, 2019

Conversation

Projects
None yet
2 participants
@jatinkumarg
Copy link
Contributor

commented Apr 11, 2019

Added scroll view to the fragment library

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

@jatinkumarg jatinkumarg requested a review from mozilla-mobile/fenix as a code owner Apr 11, 2019

@ghost ghost added the review label Apr 11, 2019

@boek

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

Hey @jatinkumarg thanks for picking this up <3

@boek

boek approved these changes Apr 11, 2019

@boek boek merged commit 7bf696b into mozilla-mobile:master Apr 11, 2019

2 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
ci/bitrise/94b6dbdf37df9a7e/pr Passed - fenix
Details

@ghost ghost removed the review label Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.