Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1198: Prevents losing search input text when the screen is rotated #1545

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@jatinkumarg
Copy link
Contributor

commented Apr 11, 2019

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

@jatinkumarg jatinkumarg requested a review from mozilla-mobile/fenix as a code owner Apr 11, 2019

@ghost ghost added the review label Apr 11, 2019

@jatinkumarg jatinkumarg changed the title fix #1198: Prevents losing search input text when screen is rotated Fix #1198: Prevents losing search input text when the screen is rotated Apr 11, 2019

@colintheshots

This comment has been minimized.

Copy link
Collaborator

commented Apr 11, 2019

While I appreciate your contribution, we'd like to preserve landscape mode and rotation in our app. We're working on a more fundamental fix.

@ghost ghost removed the review label Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.