Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Publishes to a public track for the separate nightly app #4954

Conversation

mitchhentges
Copy link
Contributor

@mitchhentges mitchhentges commented Aug 27, 2019

We published to the internal track while RelMan/QA/other teams performed all the verifications need to create the separate nightly app. Once the nightly app goes public, we should automatically publish new nightlies directly to the public track (beta, in this case).

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features
  • Firefox Preview Nightly is publicly released

@mitchhentges mitchhentges requested review from a team as code owners August 27, 2019 18:15
@mitchhentges mitchhentges force-pushed the separate-nightly-app-use-public-track branch from ac19c94 to da7173d Compare August 27, 2019 20:57
Copy link
Contributor

@JohanLorenzo JohanLorenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it!

Copy link
Contributor

@pocmo pocmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@liuche
Copy link
Contributor

liuche commented Aug 29, 2019

Great! I'm still waiting on relman to get this published, linking bugzilla here: https://bugzilla.mozilla.org/show_bug.cgi?id=1575728

@boek
Copy link
Contributor

boek commented Aug 30, 2019

@liuche Is landing this blocked by relman?

@NotWoods NotWoods added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Aug 30, 2019
@liuche
Copy link
Contributor

liuche commented Aug 30, 2019

Yep, this change stops publishing nightlies to the internal track - once we have the public channel, we want to land this so we stop publishing to that internal track.

@liuche liuche removed the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Aug 30, 2019
@sblatz
Copy link
Contributor

sblatz commented Sep 10, 2019

So this should have a "do not land" label?

@liuche

@mitchhentges mitchhentges force-pushed the separate-nightly-app-use-public-track branch from da7173d to d49c2f6 Compare September 19, 2019 17:14
@mitchhentges mitchhentges requested a review from a team as a code owner September 19, 2019 17:14
@codecov-io
Copy link

codecov-io commented Sep 19, 2019

Codecov Report

Merging #4954 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4954   +/-   ##
=========================================
  Coverage     12.68%   12.68%           
  Complexity      275      275           
=========================================
  Files           251      251           
  Lines         10294    10294           
  Branches       1501     1501           
=========================================
  Hits           1306     1306           
  Misses         8897     8897           
  Partials         91       91

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2db2d9c...fe21875. Read the comment docs.

@mitchhentges mitchhentges force-pushed the separate-nightly-app-use-public-track branch from d49c2f6 to fe21875 Compare September 19, 2019 17:56
@liuche
Copy link
Contributor

liuche commented Sep 19, 2019

We have the nightly channel available on Google Play now, so this can land, to start publishing to that public channel.

We have some smoketests for PI to make sure everything is working correctly.

@liuche liuche added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Sep 19, 2019
@mitchhentges
Copy link
Contributor Author

This UI test is taking its sweet time

@liuche
Copy link
Contributor

liuche commented Sep 19, 2019

omfg i know 😭

@liuche liuche merged commit bea7943 into mozilla-mobile:master Sep 20, 2019
@JohanLorenzo
Copy link
Contributor

Thanks for taking care of it @mitchhentges !

@mitchhentges mitchhentges deleted the separate-nightly-app-use-public-track branch September 20, 2019 15:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants