-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Publishes to a public track for the separate nightly app #4954
Publishes to a public track for the separate nightly app #4954
Conversation
ac19c94
to
da7173d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Great! I'm still waiting on relman to get this published, linking bugzilla here: https://bugzilla.mozilla.org/show_bug.cgi?id=1575728 |
@liuche Is landing this blocked by relman? |
Yep, this change stops publishing nightlies to the internal track - once we have the public channel, we want to land this so we stop publishing to that internal track. |
So this should have a "do not land" label? |
da7173d
to
d49c2f6
Compare
Codecov Report
@@ Coverage Diff @@
## master #4954 +/- ##
=========================================
Coverage 12.68% 12.68%
Complexity 275 275
=========================================
Files 251 251
Lines 10294 10294
Branches 1501 1501
=========================================
Hits 1306 1306
Misses 8897 8897
Partials 91 91 Continue to review full report at Codecov.
|
d49c2f6
to
fe21875
Compare
We have the nightly channel available on Google Play now, so this can land, to start publishing to that public channel. We have some smoketests for PI to make sure everything is working correctly. |
This UI test is taking its sweet time |
omfg i know 😭 |
Thanks for taking care of it @mitchhentges ! |
We published to the
internal
track while RelMan/QA/other teams performed all the verifications need to create the separate nightly app. Once the nightly app goes public, we should automatically publish new nightlies directly to the public track (beta
, in this case).Pull Request checklist