This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
For #5063: Added parameter customTabSessionId into ContextMenuFeature #6025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntextMenuFeature Added parameter customTabSessionId into ContextMenuFeature in BaseBrowserFragment in order to show the context menu in a custom tab.
ekager
changed the title
|
bors r=ekager |
Codecov Report
@@ Coverage Diff @@
## master #6025 +/- ##
============================================
- Coverage 14.26% 14.26% -0.01%
Complexity 324 324
============================================
Files 259 259
Lines 10698 10699 +1
Branches 1560 1560
============================================
Hits 1526 1526
- Misses 9047 9048 +1
Partials 125 125
Continue to review full report at Codecov.
|
bors bot
pushed a commit
that referenced
this pull request
Oct 15, 2019
6017: For #6011 - fixed truncated clipboard icon in RTL◀️ r=ekager a=cadeyrn  6025: For #5063: Added parameter customTabSessionId into ContextMenuFeature r=ekager a=ValentinTimisica Added parameter customTabSessionId into ContextMenuFeature in BaseBrowserFragment in order to show the context menu in a custom tab. 6032: For #5990: Revert sessionTokenScope to fix broken QR pairing flow r=ekager a=grigoryk Seems like addition of sessionTokenScope is causing issues with pairing. For now, we can revert that change until the underlying issue is fixed. For #5990. Co-authored-by: Sören Hentzschel <kontakt@agenedia.com> Co-authored-by: ValentinTimisica <valentin.timisica@softvision.ro> Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
Timed out (retrying...) |
bors bot
pushed a commit
that referenced
this pull request
Oct 15, 2019
6025: For #5063: Added parameter customTabSessionId into ContextMenuFeature r=ekager a=ValentinTimisica Added parameter customTabSessionId into ContextMenuFeature in BaseBrowserFragment in order to show the context menu in a custom tab. 6032: For #5990: Revert sessionTokenScope to fix broken QR pairing flow r=ekager a=grigoryk Seems like addition of sessionTokenScope is causing issues with pairing. For now, we can revert that change until the underlying issue is fixed. For #5990. Co-authored-by: ValentinTimisica <valentin.timisica@softvision.ro> Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
Build succeeded
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added parameter customTabSessionId into ContextMenuFeature in
BaseBrowserFragment in order to show the context menu in a custom tab.
Pull Request checklist
After merge
To download an APK when reviewing a PR: