Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Closes #6097 - Bump activation ping expiry date. #6309

Merged
merged 1 commit into from
Nov 1, 2019

Conversation

liuche
Copy link
Contributor

@liuche liuche commented Oct 28, 2019


The activation ping expired, so we need to bump it to continue measuring activations of Fenix instances without overcounting.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@codecov-io
Copy link

codecov-io commented Oct 28, 2019

Codecov Report

Merging #6309 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6309   +/-   ##
=========================================
  Coverage     14.69%   14.69%           
  Complexity      328      328           
=========================================
  Files           272      272           
  Lines         11035    11035           
  Branches       1591     1591           
=========================================
  Hits           1622     1622           
  Misses         9284     9284           
  Partials        129      129

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 675fe6a...783e030. Read the comment docs.

@liuche liuche requested a review from boek October 28, 2019 23:48
@liuche
Copy link
Contributor Author

liuche commented Oct 28, 2019

Checked with Arana from BD, and this this is still something that needs to be collected. Original data review here: #1707 (comment)

app/metrics.yaml Outdated
@@ -669,7 +669,7 @@ activation:
- https://github.com/mozilla-mobile/fenix/pull/1707#issuecomment-486972209
notification_emails:
- fenix-core@mozilla.com
expires: "2019-10-01"
expires: "2019-03-01"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want to change the year here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol yes omg

@liuche liuche merged commit 35d6013 into mozilla-mobile:master Nov 1, 2019
@liuche liuche deleted the update-activation-ping branch November 1, 2019 21:06
@severinrudie severinrudie mentioned this pull request Nov 6, 2019
30 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants