Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

sync-integration-history-bookmark-fenix-desktop #7808

Merged
merged 1 commit into from
Feb 11, 2020
Merged

sync-integration-history-bookmark-fenix-desktop #7808

merged 1 commit into from
Feb 11, 2020

Conversation

isabelrios
Copy link
Contributor

This PR adds two tests so that the sync tests environment is complete in both ways Fenix <-> Desktop.

  • One test saves a Bookmark on Fenix and sign in. Then, it checks that the bookmark appears for the same FxA on Desktop
  • The other tests creates history by visiting a webiste and sign in on Fenix. Then with same FxA the history is checked on Desktop

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@codecov-io
Copy link

codecov-io commented Jan 20, 2020 •
edited
Loading

Codecov Report

Merging #7808 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7808   +/-   ##
=========================================
  Coverage     18.65%   18.65%           
  Complexity      452      452           
=========================================
  Files           316      316           
  Lines         12343    12343           
  Branches       1621     1621           
=========================================
  Hits           2303     2303           
  Misses         9841     9841           
  Partials        199      199

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a272a4...15cc4cd. Read the comment docs.

@isabelrios isabelrios marked this pull request as ready for review January 21, 2020 15:32
@isabelrios isabelrios force-pushed the sync-integration-history-bookmarks-fenix-desktop branch from 3276f14 to 3621344 Compare January 22, 2020 09:51
@isabelrios isabelrios force-pushed the sync-integration-history-bookmarks-fenix-desktop branch from 3621344 to cf163cd Compare February 10, 2020 08:40
AaronMT
AaronMT approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@AaronMT AaronMT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two comments not blocking

app/src/androidTest/java/org/mozilla/fenix/syncintegration/SyncIntegrationTest.kt
typeEmail()
tapOnContinueButton()
typePassword()
sleep(TestAssetHelper.waitingTimeShort)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have to hide the save login prompt once you sign-in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I have not found an issue with having to hide it. Once the tap on Sign In button is done, the android part of the test finishes so that prompt does not interfere with the rest of this or other tests...

app/src/androidTest/java/org/mozilla/fenix/syncintegration/SyncIntegrationTest.kt Outdated
val defaultWebPage = "example.com".toUri()!!
navigationToolbar {
}.enterURLAndEnterToBrowser(defaultWebPage) {
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be able to I think use .openThreeDotMenu here without needing to use browserScreen {}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AaronMT you are right! removing that line. Thanks!

@AaronMT AaronMT removed the request for review from rpappalax February 10, 2020 17:41
@isabelrios isabelrios force-pushed the sync-integration-history-bookmarks-fenix-desktop branch from 452cf65 to 15cc4cd Compare February 11, 2020 18:20
@isabelrios
sync-integration-history-bookmark-fenix-desktop
5f6740d 
clean code

remove unused import

fix reviewer comments
@isabelrios isabelrios force-pushed the sync-integration-history-bookmarks-fenix-desktop branch from 15cc4cd to 5f6740d Compare February 11, 2020 18:53
@AaronMT AaronMT merged commit ee544dd into mozilla-mobile:master Feb 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AaronMT AaronMT AaronMT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isabelrios @codecov-io @AaronMT