New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Bounty) Allow usage of own Firefox Sync token server #1276

Closed
schrorg opened this Issue Nov 18, 2015 · 27 comments

Comments

Projects
None yet
@schrorg
Copy link

schrorg commented Nov 18, 2015

We use an own Firefox Sync server like described in https://docs.services.mozilla.com/howtos/run-sync-1.5.html. But there is no way to configure the Firefox Sync token server URL to point to our own sync server other than modifying the source code in Account/FirefoxAccountConfiguration.swift, line 111.

Can we add an option for that? Should I do a PR?

@egogo-nl

This comment has been minimized.

Copy link

egogo-nl commented Mar 20, 2016

I would also like to see this feature added.

@acaranta

This comment has been minimized.

Copy link

acaranta commented Apr 28, 2016

bump .... That would really be a enhancement ....

@deruli79

This comment has been minimized.

Copy link

deruli79 commented Apr 29, 2016

Agree. This is really the main feature for me to leave Safari behind...

@st3fan

This comment has been minimized.

Copy link
Contributor

st3fan commented Apr 30, 2016

@schrorg We would love to see a PR for this. Do you want to work on this?

@st3fan st3fan added the needs bug label Apr 30, 2016

@dprandzioch

This comment has been minimized.

Copy link

dprandzioch commented Aug 12, 2016

Has there been any progress on this topic? I'd really love to see this feature as FF would be the only browser to support self-hosted sync across all necessary devices.

@schrorg

This comment has been minimized.

Copy link

schrorg commented Aug 13, 2016

Unfortunately I will not have the time for it during the next weeks (summer vacation, lots of other work to do...).
I will definitely keep this in mind because I still need this feature personally.

@dprandzioch

This comment has been minimized.

Copy link

dprandzioch commented Aug 13, 2016

I'm not that experienced in iOS development although I did some work in own apps already. If there's something I can help you with, please let me know.

@mehdicopter

This comment has been minimized.

Copy link

mehdicopter commented Aug 22, 2016

Any improvements on this feature ?
I'm also interested to point to my self-hosted ffsync server.
Thanks.

@egogo-nl

This comment has been minimized.

Copy link

egogo-nl commented Nov 2, 2016

Are there any updates on this? I would really like to use this feature.

@kwitaszczyk

This comment has been minimized.

Copy link

kwitaszczyk commented Jan 12, 2017

+1

@iron77

This comment has been minimized.

Copy link

iron77 commented Jan 24, 2017

I would love to see this feature being implemented as well. Shall we put a bounty on it? Any specific service you guys would recommend for this?

@mrjovanovic

This comment has been minimized.

Copy link

mrjovanovic commented Feb 5, 2017

+1 Would chip in on the bounty as well.

@iron77

This comment has been minimized.

Copy link

iron77 commented Feb 6, 2017

OK, I just started it out at Bountysource. Feel free to contribute! :)

Bountysource

@dsabanin

This comment has been minimized.

Copy link

dsabanin commented Feb 6, 2017

+1 I joined in.

@iron77

This comment has been minimized.

Copy link

iron77 commented Feb 10, 2017

@schrorg Would you consider renaming the issue topic to include "(Bounty)" in the front, so it would be more noticeable for anybody who just looks at the list of issues?

@mrjovanovic Now you have a chance :).

@ All other guys, if it's something you want to see being done soon, I'd suggest to drop few bucks on it as well :).

Also, I wonder if there's a good place to advertise the issue once the bounty gets big enough? Maybe Mozilla iOS IRC?

@schrorg schrorg changed the title Allow usage of own Firefox Sync token server (Bounty) Allow usage of own Firefox Sync token server Feb 11, 2017

@m8mble

This comment has been minimized.

Copy link

m8mble commented Mar 5, 2017

I've filed bug 1344536 for this. Starting to work on it...

@hb2708

This comment has been minimized.

Copy link

hb2708 commented Apr 30, 2017

Hello All.
@schrorg @iron77
To Cut the story short we all want the option to change the

Sync15Configuration -> tokenServerEndpointURL URL From the UI front.

Please Correct me if i am wrong.

Would Love to start working on the same. If any one have not yet started.

@cdubz

This comment has been minimized.

Copy link

cdubz commented Apr 30, 2017

Note that 1344536 has been closed and marked as a duplicate of 1204411. @st3fan, please remove the needs bug label.

@iron77

This comment has been minimized.

Copy link

iron77 commented Apr 30, 2017

@hb2708 thanks for your interest.

I might not be fully aware of how this iOS app works under the hood, but from the user perspective, I can tell you which configuration options we need there to be present.

Bringing desktop Firefox as an example, to run own Firefox Sync server, you go to about:config and set up some options pointing to where your server is. As per https://mozilla-services.readthedocs.io/en/latest/howtos/run-fxa.html and some of my testing, the options are:

  • identity.fxaccounts.auth.uri
  • identity.fxaccounts.remote.force_auth.uri
  • identity.fxaccounts.remote.oauth.uri
  • identity.fxaccounts.remote.profile.uri
  • identity.fxaccounts.remote.signin.uri
  • identity.fxaccounts.remote.signup.uri
  • identity.fxaccounts.remote.webchannel.uri
  • identity.fxaccounts.settings.uri
  • identity.sync.tokenserver.uri

I'd expect iOS app (both iPhone and iPad) to also give you some way, somewhere in UI, to set these options to custom values.

For the record, it was about a year since I last digged in that documentation, so in case I missed any option which might also be required these days, I'd appreciate the comment.

@hb2708

This comment has been minimized.

Copy link

hb2708 commented May 1, 2017

@m8mble @schrorg @iron77 Thanks but I am not aware of it on desktop.
But i can surely make it possible on iPhone and iPad apps.

If any can explain is some easy manner i would be grateful.

@cdubz So it means it's implemented or yet to be implemented?

@cdubz

This comment has been minimized.

Copy link

cdubz commented May 1, 2017

Still yet to be implemented and doesn't appear to have any traction in Bugzilla. I was just noting the updated bug number there.

@iron77

This comment has been minimized.

Copy link

iron77 commented May 4, 2017

@hb2708 I can try to explain it as easy as possible. Just so I better understand where to start, can you tell me:

  1. Did you ever used Firefox Sync:
    • Mozilla hosted? (default)
    • Self-hosted?
  2. If none of the above, do you have a basic understanding of what Firefox Sync is?

Sorry if questions above sound a bit stupid, I want to be fully sure we're both on the same page :)

@cwm77

This comment has been minimized.

Copy link

cwm77 commented May 5, 2017

Hi,
the only setting which needs to be changed to be editable is the analogous option to identity.sync.tokenserver.uri. In all other OSes (MacOS,WIN,Linux,Android) it was seemingly implemented at a easy way, only in iOS it seems not to be hassle-free. FF at this OS has obviously not as much in common with the other Implementations. A bing thank you in advance to the people who are in charge of this!

@rgschi-tgm

This comment has been minimized.

Copy link

rgschi-tgm commented May 11, 2017

Giving this another bump since I just upgraded to iOS10 from 7 to get Firefox on my iP. Now this missing function disappoints me a bit.

It cannot be in any way too hard to code, seems like a couple of lines only.
The problem I see would be getting this code into a release. Are the maintainers willing to accept "foreign" code?

@joeyg

This comment has been minimized.

Copy link
Contributor

joeyg commented Sep 5, 2017

Is this issue resolved now that #3088 has been merged or is additional functionality that needs to be added?

@iron77

This comment has been minimized.

Copy link

iron77 commented Sep 6, 2017

@joeyg I believe this is it! Looking forward to test it at my iDevices once it lands the App Store.

@st3fan

This comment has been minimized.

Copy link
Contributor

st3fan commented Sep 7, 2017

Yes, I am going to close this issue now that #3088 has landed. I think it has only landed on master though. @vbudhram is #3088 something we want to uplift to 9.0?

@st3fan st3fan closed this Sep 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment