Refactor FXIOS-9778 Add Multipath TCP (MPTCP) support

[Aperence]

📜 Tickets

Github issue
Jira

💡 Description

MPTCP is a TCP extension allowing to improve network reliabilty by using mutiple network interface for the same TCP connection. Check https://www.mptcp.dev and https://developer.apple.com/documentation/foundation/urlsessionconfiguration/improving_network_reliability_using_multipath_tcp for details. Changes to this repository includes introducing new configurations (defaultMPTCP/ephemeralMPTCP), replacing uses of default/ephemeral by these new configurations, introducing a sharedMPTCP property on URLSession and modifying the makeURL function to enable the handover mode by default

📝 Checklist

You have to check all boxes before merging

• Filled in the above information (tickets numbers and description of your work)
• Updated the PR name to follow our PR naming guidelines
• Wrote unit tests and/or ensured the tests suite is passing
• When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
• If needed, I updated documentation / comments for complex code and public methods
• If needed, added a backport comment (example @Mergifyio backport release/v120)

[mattreaganmozilla]

Thanks for this PR @Aperence. Might be good to get some extra eyes on this (cc @nbhasin2).

[nbhasin2]

Approving with minor nits

[nbhasin2]

@Aperence I see the following tests failing, would you mind looking into it and let us know if any support is required

[Aperence]

Hello, I've fixed the issues with these tests normally

[mobiletest-ci-bot]

	Messages
📖	Project coverage: 31.56%
📖	Edited 18 files
📖	Created 2 files

Client.app: Coverage: 30.09

File	Coverage
BrowserViewController.swift	5.07%	⚠️
TemporaryDocument.swift	0.0%	⚠️
URLSessionConfiguration+defaultMPTCP.swift	100.0%	✅
PocketProvider.swift	86.21%	✅
WallpaperNetworkModule.swift	100.0%	✅
DownloadQueue.swift	50.15%	✅
BreachAlertsClient.swift	0.0%	⚠️
ActionProviderBuilder.swift	0.0%	⚠️
SearchSuggestClient.swift	72.45%	✅
ContileProvider.swift	90.91%	✅
OpenPassBookHelper.swift	0.0%	⚠️

Generated by 🚫 Danger Swift against ea7dc48

[nbhasin2]

Thanks @Aperence, somehow the warnings have increased. Let me re-run the build but I would suggest trying locally to check the warnings between main / your branch

Just posting in this file to have a chain of comments

[Aperence]

Hello @nbhasin2,

Thank you for the review first.
After having checked the code, it seems like it was simply 2 immutable variables that were declared with a var keyword, instead of let. This should be fixed normally.

Also, I've seen that I forgot to add the Multipath entitlement, I've just added it now (if it is fine ?).

Have a nice day

[nbhasin2]

Ah sorry, totally missed this. Let me double check to see if this is valid.

@Aperence did you try it locally or simply added it where it needs to get added?

Thanks again

[Aperence]

I built locally the application to make sure that it doesn’t generate new warnings.

Thanks again for the follow-up !

[mergify]

This pull request has conflicts when rebasing. Could you fix it @Aperence? 🙏

[Aperence]

Rebased it normally !

[github-actions]

This PR has been automatically marked as stale. Please leave any comment to keep this PR opened. It will be closed automatically if no further update occurs in the next 7 days. Thank you for your contributions!

[Aperence]

Any news about this ?

[OrlaM]

I'm surprised this isn't just default URLSession behaviour and it's very strange that Apple require an entitlement for it 🤔
Great change either way, one minor nit otherwise LGTM

[Aperence]

Just applied the requested change. It probably isn't enabled by default because some time ago, some other options weren't (well) supported with MPTCP (from what I know), and they probably never reconsidered up to now to enable it by default.

[nbhasin2]

Running BR and if all looks well I can merge it in 🤞🏼

[nbhasin2]

@Aperence might wanna rebase this one last time as you have approvals but there are certain number of warnings that are more on this PR compared to main.

Thanks and once green I can hit merge

[Aperence]

Just rebased it now, hope it will fix the warnings