Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1309571 - Fix visitDate ordering for history recommendation results #2231

Merged
merged 1 commit into from Nov 15, 2016

Conversation

sleroux
Copy link

@sleroux sleroux commented Nov 10, 2016

SQL was off for the highlights query which resulted in items being pulled in that were a month old!

@sleroux sleroux force-pushed the sleroux/Bug1309571-MonthOldStuff branch from ad949c8 to 223c8b9 Compare November 10, 2016 15:40
@sleroux sleroux changed the title Bug 1309581 - Fix visitDate ordering for history recommentation results Bug 1309571 - Fix visitDate ordering for history recommentation results Nov 10, 2016
@rnewman rnewman changed the title Bug 1309571 - Fix visitDate ordering for history recommentation results Bug 1309571 - Fix visitDate ordering for history recommendation results Nov 13, 2016
@rnewman
Copy link
Contributor

rnewman commented Nov 13, 2016

s/recommentation/recommendation.

Does this code control the history panel?

@rnewman
Copy link
Contributor

rnewman commented Nov 13, 2016

Also, recent history for me doesn't even appear in the awesomebar by string match, so I think there's another bug.

@sleroux sleroux force-pushed the sleroux/Bug1309571-MonthOldStuff branch from 223c8b9 to 6c69cc4 Compare November 15, 2016 14:44
@sleroux
Copy link
Author

sleroux commented Nov 15, 2016

Also, recent history for me doesn't even appear in the awesomebar by string match, so I think there's another bug.

Nope - just the recommendations.

@sleroux sleroux merged commit c0e77cf into master Nov 15, 2016
@sleroux sleroux deleted the sleroux/Bug1309571-MonthOldStuff branch November 15, 2016 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants