Bug 1347064 - FindInPage XCUITests #2520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabelrios
force-pushed
the
isabelrios/ConvertFindInPageUITestsToXCUITests
branch
from
0b53589
to
69bb9d3
Compare
isabelrios
force-pushed
the
isabelrios/ConvertFindInPageUITestsToXCUITests
branch
2 times, most recently
from
ac6b5e2
to
1a72b97
Compare
disabling LivePushClientTests Comment test that fails due to existing bug
|
@npark-mozilla I got the r+ from your side on the bug for this PR. But just wanted to comment and check that is ok too to add also these changes in order to be able to land this PR: Thanks! |
|
Yup that's fine to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.