Bug 1388408 - Save deferred deep link to be launched from FxA Signin #3020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@farhanpatel Since you have looked at my other Adjust patches mind an r? |
farhanpatel
approved these changes
Aug 15, 2017
st3fan
pushed a commit
that referenced
this pull request
Aug 23, 2017
st3fan
pushed a commit
that referenced
this pull request
Aug 23, 2017
jhreis
pushed a commit
to jhreis/firefox-ios
that referenced
this pull request
Oct 23, 2017
jjSDET
pushed a commit
to jjSDET/firefox-ios
that referenced
this pull request
Feb 13, 2024
* Fixes mozilla-mobile#2988 - Onboarding Refresh * Fixes mozilla-mobile#3019 - Remove old onboarding (mozilla-mobile#3020) * Fixes mozilla-mobile#3019 - Remove old onboarding * FIxes mozilla-mobile#3019 - Remove old onboarding * Fixes mozilla-mobile#2988 - Onboarding Refresh * Fixes mozilla-mobile#3027 - Restore old onboarding screen (mozilla-mobile#3028) * Fixes mozilla-mobile#3011 - Add logic for onboarding functionality (mozilla-mobile#3041) * Add onboarding event handler * Organize events handler code * Present Onboarding screen * Add logic for tooltips popups * Fixes mozilla-mobile#3011 - Add logic for onboarding functionality * Fixes mozilla-mobile#3011 - Add logic for onboarding functionality * Fixes mozilla-mobile#3011 - Add logic for onboarding functionality * Fixes mozilla-mobile#3011 - Add logic for onboarding functionality * Fixes mozilla-mobile#3011 - Add logic for onboarding functionality * Fixes - 3011 Add logic for onboarding functionality * Fixes mozilla-mobile#3011 - Add logic for onboarding functionality * Fixes mozilla-mobile#3011 - Add logic for onboarding functionality * Fixes mozilla-mobile#3011 - Add logic for onboarding functionality * Fixes mozilla-mobile#3023 Implement Onboarding first screen UI * add the necessary UI for the new onboarding screen * fix the alignment of the UI Elements in the new onboarding screen * add assets needed for the onboarding screen and will use localized text for all the labels * remove commented code * add scrollView so content will show correctly when device is in landscape * change label color depending on light/dark mode * change the onboarding screen to be light mode only * change imageViews to use lightmode only and add custom text to welcom depending on the app version * add constants to the dimensions to the StackView spacing, width/height of icons / stretch vertically the mainStackView to depict the more closely the desig / add darkmode and colors to all the labels, buttons and background * change scrollView and mainStackView constraints to work for iphone and ipad, adjust spacing to be dynamic using width and height for button and edge margins for mainStackView * remove extra spaces * change target on button to OnboardingViewController Co-authored-by: Catalin Andrei Neculaide <catalin.neculaide@softvision.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Razvan Litianu <litianu.razvan@gmail.com> * Fixes mozilla-mobile#2989 Implement Onboarding Screen * add the onboarding UI into the onboarding logic * make the new onboarding screen to not be dismissible on tap outside or drag down * change back to the old onboarding to be displayed * remove animation from old onboarding presentation * use the displayOldOnboarding property to animate presenting viewController * add a closure to dismiss functionality so the onboarding screen doesn't need to know how to dismiss himself Co-authored-by: Catalin Andrei Neculaide <catalin.neculaide@softvision.com> * Fixes mozilla-mobile#2990 Implement Shield Tooltip * Implement TooltipViewController and present shield tooltip * refact: Modify createTooltipPopover and presentTooltip methods because of redundand code * refact: change some fields as private fields, change method name createTooltipPopover in configure Co-authored-by: Sorin Paraipan <sorin.paraipan@softvision.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Fixes mozilla-mobile#3005 - Remove the home screen tips * Fixes mozilla-mobile#3005 - Remove the home screen tips * Fixes mozilla-mobile#3005 - Remove the home screen tips * Fixes mozilla-mobile#3005 - Remove the home screen tips * Fixes mozilla-mobile#3005 - Remove the home screen tips * Fixes mozilla-mobile#3005 - Remove the home screen tips Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Fixes mozilla-mobile#2992 Implement the Hamburger Menu Tooltip * feat: Implement context menu tooltip * feat: Add max size for the width of the body label of the TooltipView * refact: Add communication between TooltipViewController and the TooltipView's dismiss button using protocol - delegate pattern Co-authored-by: Sorin Paraipan <sorin.paraipan@softvision.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Fixes mozilla-mobile#2991 Implement Trash Button Tooltip * feat: Implement context menu tooltip * feat: Add max size for the width of the body label of the TooltipView * feat: Implement trash button tooltip * feat: Add possibility when rotating the device in landscape mode that the tooltip view gets anchored by the new instance of the trash button(deleteButton) * refact: Remove spaces from header Co-authored-by: Sorin Paraipan <sorin.paraipan@softvision.com> * Fixes mozilla-mobile#3059 - Menu ToolTip should appear on home screen at startup of the app * Fixes mozilla-mobile#2993 Implement the (in line) settings tooltip * add the tooltip on privacy viewcontroller * add onboarding tooltip in privacy settings as a cell in tableview * insert and delete tooltip * Convert to diffable data source * custom max width for tooltipview * reduce excessive code * make footer and header for section private properties, move to extension the hashable protocol conformance * pass the delegate into the init and assign it there * add protocol to the tooltipView cell * use the same protocol TooltipViewDelegate * change event of presenting tooltip to only appear only from settings Co-authored-by: Catalin Andrei Neculaide <catalin.neculaide@softvision.com> Co-authored-by: Razvan Litianu <litianu.razvan@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Fixes mozilla-mobile#3066 Onboarding screen layout doesn't update when device is rotating * update constraints when device rotates * change to use constants on constraints * fix minor issue Co-authored-by: Catalin Andrei Neculaide <catalin.neculaide@softvision.com> * Fixes mozilla-mobile#3071 - Implement a staging experiment for testing new vs old onboarding * Cleanup onboarding events handler (mozilla-mobile#3100) * Fixes mozilla-mobile#3069 - Menu tooltip from Home screen is not dismissed automatically * Cleanup onboarding events handler * Extract dependencies * Store viewed tips * Show new onboarding as default * Reset route on dismiss Co-authored-by: Raluca Iordan <ralucaiordan@icloud.com> * fixes: Resolve constraint issues on TooltipView (mozilla-mobile#3103) Co-authored-by: Sorin Paraipan <sorin.paraipan@softvision.com> * Add testing argument Co-authored-by: Raluca Iordan <ralucaiordan@icloud.com> Co-authored-by: Sorin Paraipan <sorin.paraipan@softvision.com> Co-authored-by: Catalin <catalin.neculaide@gmail.com> Co-authored-by: Catalin Andrei Neculaide <catalin.neculaide@softvision.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: PARAIPAN SORIN <51127880+PARAIPAN9@users.noreply.github.com>
isabelrios
pushed a commit
to isabelrios/firefox-ios
that referenced
this pull request
Feb 19, 2024
* Fixes mozilla-mobile#2988 - Onboarding Refresh * Fixes mozilla-mobile#3019 - Remove old onboarding (mozilla-mobile#3020) * Fixes mozilla-mobile#3019 - Remove old onboarding * FIxes mozilla-mobile#3019 - Remove old onboarding * Fixes mozilla-mobile#2988 - Onboarding Refresh * Fixes mozilla-mobile#3027 - Restore old onboarding screen (mozilla-mobile#3028) * Fixes mozilla-mobile#3011 - Add logic for onboarding functionality (mozilla-mobile#3041) * Add onboarding event handler * Organize events handler code * Present Onboarding screen * Add logic for tooltips popups * Fixes mozilla-mobile#3011 - Add logic for onboarding functionality * Fixes mozilla-mobile#3011 - Add logic for onboarding functionality * Fixes mozilla-mobile#3011 - Add logic for onboarding functionality * Fixes mozilla-mobile#3011 - Add logic for onboarding functionality * Fixes mozilla-mobile#3011 - Add logic for onboarding functionality * Fixes - 3011 Add logic for onboarding functionality * Fixes mozilla-mobile#3011 - Add logic for onboarding functionality * Fixes mozilla-mobile#3011 - Add logic for onboarding functionality * Fixes mozilla-mobile#3011 - Add logic for onboarding functionality * Fixes mozilla-mobile#3023 Implement Onboarding first screen UI * add the necessary UI for the new onboarding screen * fix the alignment of the UI Elements in the new onboarding screen * add assets needed for the onboarding screen and will use localized text for all the labels * remove commented code * add scrollView so content will show correctly when device is in landscape * change label color depending on light/dark mode * change the onboarding screen to be light mode only * change imageViews to use lightmode only and add custom text to welcom depending on the app version * add constants to the dimensions to the StackView spacing, width/height of icons / stretch vertically the mainStackView to depict the more closely the desig / add darkmode and colors to all the labels, buttons and background * change scrollView and mainStackView constraints to work for iphone and ipad, adjust spacing to be dynamic using width and height for button and edge margins for mainStackView * remove extra spaces * change target on button to OnboardingViewController Co-authored-by: Catalin Andrei Neculaide <catalin.neculaide@softvision.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Razvan Litianu <litianu.razvan@gmail.com> * Fixes mozilla-mobile#2989 Implement Onboarding Screen * add the onboarding UI into the onboarding logic * make the new onboarding screen to not be dismissible on tap outside or drag down * change back to the old onboarding to be displayed * remove animation from old onboarding presentation * use the displayOldOnboarding property to animate presenting viewController * add a closure to dismiss functionality so the onboarding screen doesn't need to know how to dismiss himself Co-authored-by: Catalin Andrei Neculaide <catalin.neculaide@softvision.com> * Fixes mozilla-mobile#2990 Implement Shield Tooltip * Implement TooltipViewController and present shield tooltip * refact: Modify createTooltipPopover and presentTooltip methods because of redundand code * refact: change some fields as private fields, change method name createTooltipPopover in configure Co-authored-by: Sorin Paraipan <sorin.paraipan@softvision.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Fixes mozilla-mobile#3005 - Remove the home screen tips * Fixes mozilla-mobile#3005 - Remove the home screen tips * Fixes mozilla-mobile#3005 - Remove the home screen tips * Fixes mozilla-mobile#3005 - Remove the home screen tips * Fixes mozilla-mobile#3005 - Remove the home screen tips * Fixes mozilla-mobile#3005 - Remove the home screen tips Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Fixes mozilla-mobile#2992 Implement the Hamburger Menu Tooltip * feat: Implement context menu tooltip * feat: Add max size for the width of the body label of the TooltipView * refact: Add communication between TooltipViewController and the TooltipView's dismiss button using protocol - delegate pattern Co-authored-by: Sorin Paraipan <sorin.paraipan@softvision.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Fixes mozilla-mobile#2991 Implement Trash Button Tooltip * feat: Implement context menu tooltip * feat: Add max size for the width of the body label of the TooltipView * feat: Implement trash button tooltip * feat: Add possibility when rotating the device in landscape mode that the tooltip view gets anchored by the new instance of the trash button(deleteButton) * refact: Remove spaces from header Co-authored-by: Sorin Paraipan <sorin.paraipan@softvision.com> * Fixes mozilla-mobile#3059 - Menu ToolTip should appear on home screen at startup of the app * Fixes mozilla-mobile#2993 Implement the (in line) settings tooltip * add the tooltip on privacy viewcontroller * add onboarding tooltip in privacy settings as a cell in tableview * insert and delete tooltip * Convert to diffable data source * custom max width for tooltipview * reduce excessive code * make footer and header for section private properties, move to extension the hashable protocol conformance * pass the delegate into the init and assign it there * add protocol to the tooltipView cell * use the same protocol TooltipViewDelegate * change event of presenting tooltip to only appear only from settings Co-authored-by: Catalin Andrei Neculaide <catalin.neculaide@softvision.com> Co-authored-by: Razvan Litianu <litianu.razvan@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Fixes mozilla-mobile#3066 Onboarding screen layout doesn't update when device is rotating * update constraints when device rotates * change to use constants on constraints * fix minor issue Co-authored-by: Catalin Andrei Neculaide <catalin.neculaide@softvision.com> * Fixes mozilla-mobile#3071 - Implement a staging experiment for testing new vs old onboarding * Cleanup onboarding events handler (mozilla-mobile#3100) * Fixes mozilla-mobile#3069 - Menu tooltip from Home screen is not dismissed automatically * Cleanup onboarding events handler * Extract dependencies * Store viewed tips * Show new onboarding as default * Reset route on dismiss Co-authored-by: Raluca Iordan <ralucaiordan@icloud.com> * fixes: Resolve constraint issues on TooltipView (mozilla-mobile#3103) Co-authored-by: Sorin Paraipan <sorin.paraipan@softvision.com> * Add testing argument Co-authored-by: Raluca Iordan <ralucaiordan@icloud.com> Co-authored-by: Sorin Paraipan <sorin.paraipan@softvision.com> Co-authored-by: Catalin <catalin.neculaide@gmail.com> Co-authored-by: Catalin Andrei Neculaide <catalin.neculaide@softvision.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: PARAIPAN SORIN <51127880+PARAIPAN9@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes https://github.com/mozilla/fxa-bugzilla-mirror/issues/354 and https://github.com/mozilla/fxa-bugzilla-mirror/issues/346.
Deferred deeplinking had inconsistent results. This was because any interstitial view launched before the deeplink, would cause Adjust not to process the link. This PR allows the
IntroViewControllerto correctly handle these scenarios.