Bug 1401783 - Use simple matching for extensions.

[rnewman]

No description provided.

[rnewman]

This basically means "match this against any attachment". The v1 behavior was "pass if this matches every attachment".

[st3fan]

It would be really nice if this worked well. Before we land this we just need to make sure our extensions work correctly from Firefox, Safari, Chrome, Twitter & a few other that share URL data. Specially make sure the behaviour is the same - that we get both title and url.

[garvankeeley]

FYI, the 'compiled' query in the failing case looks like this:

`SUBQUERY ( extensionItems, , SUBQUERY ( , , ANY  UTI-CONFORMS-TO "public.url").@count == 1 ).@count == 1`

Those empty parameters look like the problem.

I found an older Client.app in the build folder, and it looks like this is what a working compiled PlugIns/<extension>/Info.plist would have:

SUBQUERY ( extensionItems, $extensionItem, SUBQUERY ( $extensionItem.attachments, $attachment, ANY $attachment.registeredTypeIdentifiers UTI-CONFORMS-TO "public.url").@count > 0 ).@count == 1

The former instance is Xcode 9 release, the latter I believe was compiled on Xcode 9 GM, which leads me to believe there was a change between GM and release.

[garvankeeley]

@st3fan can we land on master and ask QA to run through this extensively?

edit: just now saw your comment to land and then QA it, sgtm.