Bug 1506791 - drag reorder and delete is crashing. let's not. #4390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. But tests arent compiling |
The fix is to ignore the drag and reload the collection view. It would be nice-to-have if the drag could be animated back to exit the drag state, but Apple APIs do not expose that level of control. All we can do is ignore the drag.
garvankeeley
force-pushed
the
garvan/bug-1506791-dandd
branch
from
d2ef172
to
a15145d
Compare
|
Oops, is 100% more buildy now. |
farhanpatel
reviewed
Nov 27, 2018
SwiftLint found issuesWarnings
Generated by 🚫 Danger |
farhanpatel
approved these changes
Nov 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is to ignore the drag and reload the collection view.
It would be nice-to-have if the drag could be animated back to exit the
drag state, but Apple APIs do not expose that level of control. All we
can do is ignore the drag.
I was trying to do something similar before this patch (by just ignoring the drag), but that was insufficient, the collection view needs to be reloaded fully.