Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the Launch Screen to use System Background Color #5608

Merged

Conversation

@ryanmcgrath
Copy link
Contributor

ryanmcgrath commented Oct 13, 2019

This changes the Launch Screen xib to use the system background color rather than stock white. Currently on iOS13 when you open the app it's a (blinding) white - i.e, my wife becomes annoyed when I do this at night. :)

By using the system background color, iOS will make it black or white depending on if the user has dark mode toggled in their settings.

Slightly unrelated, but you may want to push out a release of this soon if possible - unless I'm mistaken, the App Store version isn't linked against iOS13, and WKWebView isn't respecting prefers-dark-colors in CSS as a result. I can file it as a bug if you'd like, but it feels like overkill considering any release would hit it.

…ound color, so that people in dark mode aren't blinded when they open the app (forces a darker background instead of white)
@@ -18,7 +21,7 @@
</constraints>
</imageView>
</subviews>
<color key="backgroundColor" white="1" alpha="1" colorSpace="custom" customColorSpace="calibratedWhite"/>
<color key="backgroundColor" systemColor="systemBackgroundColor" cocoaTouchSystemColor="whiteColor"/>

This comment has been minimized.

Copy link
@garvankeeley

garvankeeley Oct 16, 2019

Contributor

Thanks for the PR! Can you unstage the other changes if this is the only needed change? Thanks

This comment has been minimized.

Copy link
@ryanmcgrath

ryanmcgrath Oct 16, 2019

Author Contributor

Should be good now!

@ryanmcgrath

This comment has been minimized.

Copy link
Contributor Author

ryanmcgrath commented Oct 16, 2019

@garvankeeley garvankeeley merged commit 6eca44a into mozilla-mobile:master Oct 18, 2019
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
garvankeeley added a commit that referenced this pull request Oct 21, 2019
garvankeeley added a commit that referenced this pull request Nov 15, 2019
* Change the Launch Screen to use System Background Color as the background color, so that people in dark mode aren't blinded when they open the app (forces a darker background instead of white)

* Clean up LaunchScreen.xib to only change the systemBackgroundColor item
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.