New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs 1120827, 1120831: Improve accessibility #77

Merged
merged 2 commits into from Jan 21, 2015

Conversation

Projects
None yet
2 participants
@dusek
Contributor

dusek commented Jan 12, 2015

Add accessibility labels etc. for buttons and other elements whose function is conveyed mostly visually. Also provide VoiceOver scrub gesture where convenient.

Submitted under MPL v2.0 by my employer, A11Y LTD.

@thebnich

This comment has been minimized.

Contributor

thebnich commented Jan 13, 2015

Thanks for the PR! Can you please file a bug, then update the title of this PR to reference that bug #? You can use the other open PRs as a reference if helpful.

@dusek dusek changed the title from Improve accessibility to Bugs 1120827, 1120831: Improve accessibility Jan 13, 2015

@dusek

This comment has been minimized.

Contributor

dusek commented Jan 13, 2015

Thanks for the quick turnaround. I did:

  • submit the bugs
  • reference them in the title of the PR
  • reference them in individual commit message titles
  • rebased on current master while I was at it
  • added note to this PR that we are OK with MPLv2.0

Please let me know if there is anything else to make a contribution properly, it's my first time contributing to Mozilla. :-)

@dusek

This comment has been minimized.

Contributor

dusek commented Jan 18, 2015

I made some updates:

  • rebased to latest code
  • reflected latest code (address field becomes address and search field)
  • added accessibility label to avatar image, secure connection image, reader button, search suggestions for search engines
@thebnich

This comment has been minimized.

Contributor

thebnich commented Jan 21, 2015

Thanks for the contribution!

Unfortunately, it looks like this got bitrotted by #100. Would you mind rebasing this PR so we can merge it?

dusek added some commits Jan 12, 2015

Bug 1120827: Fix accessibility of UI elements
Add accessibility labels to elements that use visual cues to fully or
partially communicate their functions:
- back and forward button
- show tabs button
- secure connection
- reader
- address and search text field
- search engine in search suggestion
- avatar
Bug 1120831: Add accessibility escape ("scrub") shortcuts
This allows for better VoiceOver user experience as the user does not
have to go to the cancel button in tab bar or to the back button in
toolbar to invoke them and instead can use the scrub gesture from
anywhere.
@dusek

This comment has been minimized.

Contributor

dusek commented Jan 21, 2015

Would you mind rebasing this PR so we can merge it?

Done.

@thebnich

This comment has been minimized.

Contributor

thebnich commented Jan 21, 2015

Looks great, thanks!

thebnich added a commit that referenced this pull request Jan 21, 2015

Merge pull request #77 from dusek/accessibility
Bugs 1120827, 1120831: Improve accessibility

@thebnich thebnich merged commit 60cd295 into mozilla-mobile:master Jan 21, 2015

@dusek dusek deleted the dusek:accessibility branch Apr 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment