Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1123055: Respect "Darken colors" accessibility setting #97

Merged
merged 1 commit into from Jan 21, 2015

Conversation

@dusek
Copy link
Contributor

@dusek dusek commented Jan 19, 2015

This does not yet support responding to notifications of changes to the
setting.

The only changes that I could test were in "Share To" and in History
table, as other parts of UI seem not to work yet.

This does not yet support responding to notifications of changes to the
setting.
thebnich added a commit that referenced this issue Jan 21, 2015
Bug 1123055: Respect "Darken colors" accessibility setting
@thebnich thebnich merged commit 28d4300 into mozilla-mobile:master Jan 21, 2015
@thebnich
Copy link
Contributor

@thebnich thebnich commented Jan 21, 2015

Thanks. We should probably create a theme class to group this stuff together instead of having colors/accessibility checks spread out everywhere, but this should be OK for now.

@dusek
Copy link
Contributor Author

@dusek dusek commented Jan 21, 2015

My thoughts too about some theme class. More when I consider what will need to be done with fonts, as based on different accessibility (or partly accessibility) settings, we might choose to use:

  • bolder font (accessibility setting to use bold text)
  • bigger font (dynamic type size user setting, and accessibility provides even bigger values for this setting)

I will log these two as bugs in the coming days.

@dusek dusek deleted the accessibility-darken-colors branch Apr 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants