Skip to content
This repository has been archived by the owner. It is now read-only.

Integrate FxA Accounts Component #2445

Closed
athomasmoz opened this issue Jun 14, 2019 · 6 comments
Closed

Integrate FxA Accounts Component #2445

athomasmoz opened this issue Jun 14, 2019 · 6 comments

Comments

@athomasmoz
Copy link

@athomasmoz athomasmoz commented Jun 14, 2019

Why/User Benefit/User Problem

As an FFTV eng, I want to re-use the A-C component for accounts, so that I don't need to recreate & maintain a separate version for FFTV

Acceptance Criteria (how do I know when I’m done?)

  • FxA accounts component integrated into FFTV codebase
  • Can load sign-in page

Not included

  • UI for signing in doesn't need to be polished #2441

TODO:

@liuche
Copy link
Contributor

@liuche liuche commented Jun 28, 2019

Have never seen this component before, will look at Fenix codebase.

@liuche liuche added the size M label Jun 28, 2019
@mcomella mcomella self-assigned this Jul 1, 2019
liuche added a commit to liuche/firefox-tv that referenced this issue Jul 2, 2019
liuche added a commit to liuche/firefox-tv that referenced this issue Jul 2, 2019
liuche added a commit that referenced this issue Jul 2, 2019
liuche added a commit that referenced this issue Jul 2, 2019
@mcomella
Copy link
Contributor

@mcomella mcomella commented Jul 3, 2019

Status update: I've got an account logged in end-to-end with hacky code. Before we can merge, I should clean it up (into our architecture). Then we can parallelize:

  • Fixing the sign in experience (bug is filed)
  • Correctly updating the state as part of our architecture
mcomella added a commit to mcomella/firefox-tv that referenced this issue Jul 3, 2019
mcomella added a commit to mcomella/firefox-tv that referenced this issue Jul 3, 2019
mcomella added a commit to mcomella/firefox-tv that referenced this issue Jul 3, 2019
@athomasmoz athomasmoz added this to To Do in Skyline via automation Jul 4, 2019
@athomasmoz athomasmoz moved this from To Do to In Progress in Skyline Jul 4, 2019
mcomella added a commit to mcomella/firefox-tv that referenced this issue Jul 9, 2019
mcomella added a commit to mcomella/firefox-tv that referenced this issue Jul 9, 2019
@mcomella mcomella mentioned this issue Jul 9, 2019
1 of 1 task complete
mcomella added a commit to mcomella/firefox-tv that referenced this issue Jul 10, 2019
mcomella added a commit to mcomella/firefox-tv that referenced this issue Jul 10, 2019
mcomella added a commit to mcomella/firefox-tv that referenced this issue Jul 10, 2019
mcomella added a commit to mcomella/firefox-tv that referenced this issue Jul 10, 2019
mcomella added a commit to mcomella/firefox-tv that referenced this issue Jul 10, 2019
mcomella added a commit to mcomella/firefox-tv that referenced this issue Jul 10, 2019
…onfig.
mcomella added a commit to mcomella/firefox-tv that referenced this issue Jul 10, 2019
…onfig.
@mcomella mcomella mentioned this issue Jul 10, 2019
2 of 5 tasks complete
mcomella added a commit to mcomella/firefox-tv that referenced this issue Jul 11, 2019
@mcomella
Copy link
Contributor

@mcomella mcomella commented Jul 11, 2019

Status update: open PR. We'll need to rebase on breaking changes in the next a-c release, I'd like to write tests, and I should help improve the docs though.

mcomella added a commit to mcomella/firefox-tv that referenced this issue Jul 16, 2019
…onfig.
mcomella added a commit to mcomella/firefox-tv that referenced this issue Jul 16, 2019
mcomella added a commit to mcomella/firefox-tv that referenced this issue Jul 16, 2019
mcomella added a commit to mcomella/firefox-tv that referenced this issue Jul 16, 2019
mcomella added a commit to mcomella/firefox-tv that referenced this issue Jul 16, 2019
… clearer explanation.
mcomella added a commit to mcomella/firefox-tv that referenced this issue Jul 16, 2019
mcomella added a commit to mcomella/firefox-tv that referenced this issue Jul 16, 2019
… code.
mcomella added a commit to mcomella/firefox-tv that referenced this issue Jul 16, 2019
mcomella added a commit that referenced this issue Jul 16, 2019
mcomella added a commit that referenced this issue Jul 16, 2019
mcomella added a commit that referenced this issue Jul 16, 2019
@mcomella
Copy link
Contributor

@mcomella mcomella commented Jul 16, 2019

Closed in #2513; follow-ups in #2538.

@mcomella mcomella closed this Jul 16, 2019
Skyline automation moved this from In Progress to Done Jul 16, 2019
@mcomella
Copy link
Contributor

@mcomella mcomella commented Jul 24, 2019

qa-ready: the feature can be enabled with the SendTab-2511:B flag. The implemented experience is defined in the acceptance criteria.

Limitations:

  • Sign in button uses placeholder icon in nav overlay. Currently, it's "CC" next to the "Exit Firefox" button
  • After signing in, the behavior after clicking "Sign in" again is undefined.
  • After signing in, the only artifact that indicates that the user is signed is the "Sign in success" status page.
  • Content is loaded into the tab the user is using to browse content. The sign in page acts like any other page the user loaded. This is not necessarily intended to be the final experience (e.g. we may clear those items from the history stack in the future and return the user to the site they last browsed to)
@abodea
Copy link
Member

@abodea abodea commented Jul 26, 2019

Verified as fixed in the latest LAT 4.1-LAT2, I was able to activate the feature and I added bugs accordingly.

@severinrudie severinrudie mentioned this issue Jul 31, 2019
2 of 5 tasks complete
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants