Skip to content
This repository was archived by the owner on Jan 12, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mozilla-mobile/focus-android
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c1bcc59c79bc31beb3eb1cfa3782faa8d92846f1
Choose a base ref
...
head repository: mozilla-mobile/focus-android
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 09784e886254ae6a398b7156930ebd7efeb2dd91
Choose a head ref
  • 15 commits
  • 20 files changed
  • 1 contributor

Commits on May 22, 2017

  1. Import Locales and BrowserLocaleManager from fennec (#122)

    @ahunt
    ahunt committed May 22, 2017
    Configuration menu
    Copy the full SHA
    5790ed1 View commit details
    Browse the repository at this point in the history

  2. Remove old Locales and adjust tests (#122) 

    The Locales code has already been copied into new Locales.
    @ahunt
    ahunt committed May 22, 2017
    Configuration menu
    Copy the full SHA
    e9b1e73 View commit details
    Browse the repository at this point in the history

  3. Move Locales into multiple claseses (#122)

    @ahunt
    ahunt committed May 22, 2017
    Configuration menu
    Copy the full SHA
    bbab173 View commit details
    Browse the repository at this point in the history

  4. Ensure HomeFragment is Locale-Aware (#122)

    @ahunt
    ahunt committed May 22, 2017
    Configuration menu
    Copy the full SHA
    61f17b0 View commit details
    Browse the repository at this point in the history

  5. Make BrowserFragment LocaleAware (#122) 

    We don't actually show any String in this fragment, so we don't need
to perform any changes (the menu is reinitalised every time its shown,
so the locale there is updated dynamically and independently of the
fragment).
    @ahunt
    ahunt committed May 22, 2017
    Configuration menu
    Copy the full SHA
    02b4b77 View commit details
    Browse the repository at this point in the history

  6. Make MainActivity Locale-Aware (#122)

    @ahunt
    ahunt committed May 22, 2017
    Configuration menu
    Copy the full SHA
    d497b05 View commit details
    Browse the repository at this point in the history

  7. Make FocusApplication Locale-Aware (#122) 

    LocaleAwareApplication takes care of the relevant context and config
changes.
    @ahunt
    ahunt committed May 22, 2017
    Configuration menu
    Copy the full SHA
    f23e661 View commit details
    Browse the repository at this point in the history

  8. Make the locale list complete (#122)

    @ahunt
    ahunt committed May 22, 2017
    Configuration menu
    Copy the full SHA
    bbc35bc View commit details
    Browse the repository at this point in the history

  9. Add basic locale switcher to Settings (#122)

    @ahunt
    ahunt committed May 22, 2017
    Configuration menu
    Copy the full SHA
    05251d9 View commit details
    Browse the repository at this point in the history

  10. Make Settings Locale-Aware (#122)

    @ahunt
    ahunt committed May 22, 2017
    Configuration menu
    Copy the full SHA
    44a9778 View commit details
    Browse the repository at this point in the history

  11. Import LocaleListPreference from Fennec (#122)

    @ahunt
    ahunt committed May 22, 2017
    Configuration menu
    Copy the full SHA
    7ca99e4 View commit details
    Browse the repository at this point in the history

  12. Upgrade to LocaleListPreference (#122)

    @ahunt
    ahunt committed May 22, 2017
    Configuration menu
    Copy the full SHA
    e593d40 View commit details
    Browse the repository at this point in the history

  13. Initialise LocaleListPreference in onAttachedToActivity (#122) 

    We don't need the data early, and this is run during startup (setting
default preferences also means that each Preference class is constructed).
    @ahunt
    ahunt committed May 22, 2017
    Configuration menu
    Copy the full SHA
    2d55514 View commit details
    Browse the repository at this point in the history

  14. findbugs: fix LocaleListPreference (#122)

    @ahunt
    ahunt committed May 22, 2017
    Configuration menu
    Copy the full SHA
    05de1cd View commit details
    Browse the repository at this point in the history

  15. Initialise CharacterValidator late too (#122) 

    1. This causes test failures, see the comments about bytes per pixel.
2. We shouldn't do this at construction time anyway: loading default
   preferences (which occurs at app startup) results in all Preference
   classes being constructed, and we don't want to go drawing bitmaps
   at startup.
    @ahunt
    ahunt committed May 22, 2017
    Configuration menu
    Copy the full SHA
    09784e8 View commit details
    Browse the repository at this point in the history
Loading