Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct status bar height on multiwindow #2278

Closed

Conversation

Projects
None yet
2 participants
@fercarcedo
Copy link
Contributor

commented Mar 10, 2018

This PR solves the problem of the status bar height not adjusting when going from multiwindow to fullscreen or vice versa.

The solution consists of querying the status bar height on onResume since it's the callback we get when entering/leaving multiwindow, and we cannot remove the WindowInsets listener due to the fact that when resizing the window (such as, for example, when resizing to go fullscreen) we don't get any lifecycle callback (such as onStart or onResume), instead the listener gets triggered.

#2275

@pocmo pocmo self-requested a review Mar 12, 2018

@pocmo pocmo added the needs review label Mar 12, 2018

@pocmo

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2018

@fercarcedo

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2018

The wildcard import is now removed

@pocmo

pocmo approved these changes Mar 16, 2018

@pocmo

This comment has been minimized.

Copy link
Contributor

commented Mar 16, 2018

LGTM. Found another issue and filed #2316.

@pocmo

This comment has been minimized.

Copy link
Contributor

commented Mar 16, 2018

Due to a merge conflict I'm landing this separately in #2317

@pocmo pocmo closed this Mar 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.