This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
Fix Issue 1557 - Fix alignment issues for toggle cells in the settings view #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sblatz
suggested changes
Nov 19, 2018
| @@ -416,7 +458,9 @@ class SettingsViewController: UIViewController, UITableViewDataSource, UITableVi | |||
| cell.accessibilityIdentifier = "settingsViewController.trackingCell" | |||
| cell.accessoryType = .disclosureIndicator | |||
| } else { | |||
| cell = getToggleCell(indexPath: indexPath) | |||
| let toggle = toggleForIndexPath(indexPath) | |||
| cell = SettingsTableViewToggleCell(style: .subtitle, reuseIdentifier: "toggleCell", toggle: toggle) | |||
There was a problem hiding this comment.
This is a lot of code duplication right now (these three lines are repeated thrice) are we able to reduce it somehow?
|
@sblatz I added a function to make it simpler to setup the cell without having to copy 3 lines whenever making a toggle cell. Let me know if that's what you were looking for :) |
sblatz
approved these changes
Nov 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue 1557
Made a new cell similar to the SettingsViewTableAccessoryCell to fix the layout issues of the toggle cells.