Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web content behind lock icon clickable #448

Closed
pocmo opened this issue Jan 19, 2019 · 1 comment

Comments

2 participants
@pocmo
Copy link
Contributor

commented Jan 19, 2019

From reddit:

PPS if you want a bug:- tap on the padlock icon in the toolbar. The tap goes through the toolbar and taps on the document behind and e.g. opens a link on the document. Presumably it'll be fixed when the padlock is plumbed in to Tracking Protection screen?

@pocmo pocmo added the 🐞 bug label Jan 19, 2019

@Amejia481 Amejia481 self-assigned this Jan 21, 2019

@Amejia481 Amejia481 moved this from R-B bugs to Sprint Backlog in Android Components Sprint Planning Jan 21, 2019

@Amejia481 Amejia481 moved this from Sprint Backlog to In Progress in Android Components Sprint Planning Jan 26, 2019

@Amejia481

This comment has been minimized.

Copy link
Contributor

commented Jan 27, 2019

It's weird that AppCompatImageView allows text to be selectable when it dosen't have click listener.

<android.support.design.widget.CoordinatorLayout
        xmlns:android="http://schemas.android.com/apk/res/android"
        xmlns:app="http://schemas.android.com/apk/res-auto"
        xmlns:tools="http://schemas.android.com/tools"
        xmlns:mozac="http://schemas.android.com/apk/res-auto"
        android:layout_width="match_parent"
        android:layout_height="match_parent"
        tools:context=".BrowserActivity">


    <FrameLayout
            android:layout_width="match_parent"
            android:layout_height="match_parent">

        <TextView android:layout_width="wrap_content"
                  android:layout_height="wrap_content"
                  android:textIsSelectable="true"
                  android:text="Mozilla Campus Clubs will be replacing the FSA program and so we won’t be accepting any new Firefox Student Ambassadors. The listed FSA Activities won’t be carried any more. You can find more information about the future of the program in this post, where you can also leave your questions. Mozilla Campus Clubs will be replacing the FSA program and so we won’t be accepting any new Firefox Student Ambassadors. The listed FSA Activities won’t be carried any more. You can find more information about the future of the program in this post, where you can also leave your questions. Mozilla Campus Clubs will be replacing the FSA program and so we won’t be accepting any new Firefox Student Ambassadors. The listed FSA Activities won’t be carried any more. You can find more information about the future of the program in this post, where you can also leave your questions. Mozilla Campus Clubs will be replacing the FSA program and so we won’t be accepting any new Firefox Student Ambassadors. The listed FSA Activities won’t be carried any more. You can find more information about the future of the program in this post, where you can also leave your questions. Mozilla Campus Clubs will be replacing the FSA program and so we won’t be accepting any new Firefox Student Ambassadors. The listed FSA Activities won’t be carried any more. You can find more information about the future of the program in this post, where you can also leave your questions. Mozilla Campus Clubs will be replacing the FSA program and so we won’t be accepting any new Firefox Student Ambassadors. The listed FSA Activities won’t be carried any more. You can find more information about the future of the program in this post, where you can also leave your questions. Mozilla Campus Clubs will be replacing the FSA program and so we won’t be accepting any new Firefox Student Ambassadors. The listed FSA Activities won’t be carried any more. You can find more information about the future of the program in this post, where you can also leave your questions. Mozilla Campus Clubs will be replacing the FSA program and so we won’t be accepting any new Firefox Student Ambassadors. The listed FSA Activities won’t be carried any more. You can find more information about the future of the program in this post, where you can also leave your questions. Mozilla Campus Clubs will be replacing the FSA program and so we won’t be accepting any new Firefox Student Ambassadors. The listed FSA Activities won’t be carried any more. You can find more information about the future of the program in this post, where you can also leave your questions. Mozilla Campus Clubs will be replacing the FSA program and so we won’t be accepting any new Firefox Student Ambassadors. The listed FSA Activities won’t be carried any more. You can find more information about the future of the program in this post, where you can also leave your questions. Mozilla Campus Clubs will be replacing the FSA program and so we won’t be accepting any new Firefox Student Ambassadors. The listed FSA Activities won’t be carried any more. You can find more information about the future of the program in this post, where you can also leave your questions. "  />

        <android.support.v7.widget.AppCompatImageView
                android:layout_width="match_parent"
                android:layout_height="100dp"
                android:src="@drawable/mozac_ic_lock"
                android:layout_gravity="top"
                android:tint="#030303"
        />
    </FrameLayout>

</android.support.design.widget.CoordinatorLayout>

image

@pocmo pocmo closed this Jan 28, 2019

Android Components Sprint Planning automation moved this from In Progress to Done Jan 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.