Add history syncing #222
Closed
Add history syncing #222
Conversation
|
This was done via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This is a WIP for history syncing, which depends on mozilla-mobile/android-components#1409
This has some hacks to change the FxA servers we use from production to https://latest.dev.lcip.org - this is because production hasn't all the config changes necessary to support what we need to do here - @rfk can elaborate if necessary. While we will probably not want to merge these changes, I restructured things a little so that it's much easier to change FxA stacks by changing just one constant - it might make sense to merge that refactor even if we can use prod by the time this is merged.
I've also made an attempt to update the last-sync timestamp, but the timestamp doesn't update immediately after pressing "sync now" as I wasn't sure whether to (and how to best) introduce a custom coroutine scope here.
This also doesn't look at the "choose what to sync" prefs - it unconditionally syncs history even if that option is de-selected - but that might be OK for an initial landing.
cc @eoger, @thomcc