New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add history syncing #222

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@mhammond
Contributor

mhammond commented Nov 19, 2018

This is a WIP for history syncing, which depends on mozilla-mobile/android-components#1409

This has some hacks to change the FxA servers we use from production to https://latest.dev.lcip.org - this is because production hasn't all the config changes necessary to support what we need to do here - @rfk can elaborate if necessary. While we will probably not want to merge these changes, I restructured things a little so that it's much easier to change FxA stacks by changing just one constant - it might make sense to merge that refactor even if we can use prod by the time this is merged.

I've also made an attempt to update the last-sync timestamp, but the timestamp doesn't update immediately after pressing "sync now" as I wasn't sure whether to (and how to best) introduce a custom coroutine scope here.

This also doesn't look at the "choose what to sync" prefs - it unconditionally syncs history even if that option is de-selected - but that might be OK for an initial landing.

cc @eoger, @thomcc

@mhammond mhammond requested a review from mozilla-mobile/act as a code owner Nov 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment