0.8.1: explicitly pass taskId and runId from the azure json #17

Merged
merged 2 commits into from Oct 18, 2016

Projects

None yet

3 participants

@escapewindow
Member

I've been assuming that message_info['task_info'] will always look like

{
    "taskId": "...",
    "runId": 0
}

However, in this changeset, @jonasfj added a hintId.

This change explicitly passes taskId and runId rather than using message_info['task_info'] as kwargs.

After pushing this patch, and a puppet-specific change, to puppet, the signing scriptworkers began claiming new tasks again.

@escapewindow escapewindow explicitly pass taskId and runId from the azure json
d782b04
@escapewindow
Member

@JohanLorenzo if you're up for it, I'd love a review :)

@coveralls

Coverage Status

Coverage remained the same at 100.0% when pulling d782b04 on escapewindow:fix-loop into 14e7836 on mozilla-releng:master.

@JohanLorenzo

These changes (caused by PR taskcluster/taskcluster-queue#124) make sense to me.

@escapewindow escapewindow 0.8.1
9648f2a
@coveralls

Coverage Status

Coverage remained the same at 100.0% when pulling 9648f2a on escapewindow:fix-loop into 14e7836 on mozilla-releng:master.

@escapewindow escapewindow merged commit b7a5a99 into mozilla-releng:master Oct 18, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@escapewindow escapewindow deleted the escapewindow:fix-loop branch Jan 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment