This repository has been archived by the owner. It is now read-only.
Nalexander/fxa ui #381
Closed
Nalexander/fxa ui #381
Conversation
|
Phone comment, capturing for posterity: we need to introduce another state in the account state machine, which will capture the state in which we have a user's password but have not yet logged in (password => token). This is a step along the line from when we have neither (such as when a token has been invalidated). We'll temporarily enter this state when login fails after account creation, and this will be our entry point after a migration sentinel has been processed. |
|
Nothing in the UI code stands out as evil. So long as it matches the flows and functions, I'm happy. Continue to iterate! |
|
Let's close this, since it's essentially all landed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
@rnewman take a look.