/autograph

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APK Signer #61

Merged
merged 14 commits into from Mar 22, 2018

Conversation

Reviewers

@g-k g-k

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jvehent @coveralls @g-k
@jvehent
Contributor

jvehent commented Dec 29, 2017 •
edited
Edited 5 times
  • @jvehent jvehent edited Mar 19, 2018 (most recent)
  • @jvehent jvehent edited Feb 11, 2018
  • @jvehent jvehent edited Feb 11, 2018
  • @jvehent jvehent edited Jan 11, 2018
  • @jvehent jvehent edited Jan 11, 2018

WORK IN PROGRESS

  • Create an APK signer that issues PKCS7 detached signatures
  • Support SHA256 PKCS7 signatures in PKCS7 packages (without breaking XPIs)
  • Support ZIP Alignment of APK archives
  • Unit tests

@mozilla-services mozilla-services deleted a comment from coveralls Jan 11, 2018

@mozilla-services mozilla-services deleted a comment from coveralls Jan 11, 2018

@mozilla-services mozilla-services deleted a comment from coveralls Jan 11, 2018

@mozilla-services mozilla-services deleted a comment from coveralls Jan 11, 2018

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 11, 2018

Coverage Status

Coverage decreased (-3.07%) to 83.009% when pulling 4502f89 on apk into 3d8249a on master.

coveralls commented Jan 11, 2018 •
edited
Edited 1 time
  • @coveralls coveralls edited Mar 21, 2018 (most recent)

Coverage Status

Coverage decreased (-3.07%) to 83.009% when pulling 4502f89 on apk into 3d8249a on master.

jvehent added some commits Dec 29, 2017

@jvehent
initial apk signer
Verified
This commit was signed with a verified signature.
@jvehent jvehent Julien Vehent [:ulfr]
GPG key ID: A3D652173B763E8F Learn about signing commits
384c99b
@jvehent
apk: set the digest algorithm to sha256
Verified
This commit was signed with a verified signature.
@jvehent jvehent Julien Vehent [:ulfr]
GPG key ID: A3D652173B763E8F Learn about signing commits
b98079b
@jvehent
Implement APK verification
Verified
This commit was signed with a verified signature.
@jvehent jvehent Julien Vehent [:ulfr]
GPG key ID: A3D652173B763E8F Learn about signing commits
f16173b
@jvehent
Set default APK signing conf
Verified
This commit was signed with a verified signature.
@jvehent jvehent Julien Vehent [:ulfr]
GPG key ID: A3D652173B763E8F Learn about signing commits
fb5d6da
@jvehent
Add support for APK to signing client
Verified
This commit was signed with a verified signature.
@jvehent jvehent Julien Vehent [:ulfr]
GPG key ID: A3D652173B763E8F Learn about signing commits
150c587
@jvehent
Add APK signer readme
Verified
This commit was signed with a verified signature.
@jvehent jvehent Julien Vehent [:ulfr]
GPG key ID: A3D652173B763E8F Learn about signing commits
9d90859
@jvehent
working APK signer, still needs tests
Verified
This commit was signed with a verified signature.
@jvehent jvehent Julien Vehent [:ulfr]
GPG key ID: A3D652173B763E8F Learn about signing commits
d15a3e0
@jvehent
refactored tests
Verified
This commit was signed with a verified signature.
@jvehent jvehent Julien Vehent [:ulfr]
GPG key ID: A3D652173B763E8F Learn about signing commits
940c0c4
@jvehent
apk: add more unit tests
Verified
This commit was signed with a verified signature.
@jvehent jvehent Julien Vehent [:ulfr]
GPG key ID: A3D652173B763E8F Learn about signing commits
491c665
@jvehent
monitor: fix call to apk verifier
Verified
This commit was signed with a verified signature.
@jvehent jvehent Julien Vehent [:ulfr]
GPG key ID: A3D652173B763E8F Learn about signing commits
dab98d1
@jvehent
vendoring update
Verified
This commit was signed with a verified signature.
@jvehent jvehent Julien Vehent [:ulfr]
GPG key ID: A3D652173B763E8F Learn about signing commits
Loading status checks…
e81f539
@g-k

g-k reviewed Mar 21, 2018
View changes

👍 Looks good so far.

Show outdated Hide outdated tools/autograph-client/client.go
@@ -201,3 +232,7 @@ func verifyXPI(input []byte, resp signatureresponse) bool {
}
return true
}
func verifyAPK(input []byte, resp signatureresponse) bool {
return true

This comment has been minimized.

Show comment
Hide comment
@g-k

g-k Mar 21, 2018

Contributor

is this still WIP?
Copy URL
@g-k

g-k Mar 21, 2018

Contributor

is this still WIP?

This comment has been minimized.

Show comment
Hide comment
@jvehent

jvehent Mar 21, 2018

Contributor

errr nope I should fix this
Copy URL
@jvehent

jvehent Mar 21, 2018

Contributor

errr nope I should fix this
@jvehent
autograph-client: fix all the things
Verified
This commit was signed with a verified signature.
@jvehent jvehent Julien Vehent [:ulfr]
GPG key ID: A3D652173B763E8F Learn about signing commits
Loading status checks…
a23508d

@jvehent jvehent dismissed g-k’s stale review via a23508d Mar 21, 2018

@jvehent
apk: improve readme
Verified
This commit was signed with a verified signature.
@jvehent jvehent Julien Vehent [:ulfr]
GPG key ID: A3D652173B763E8F Learn about signing commits
Loading status checks…
4502f89

@jvehent jvehent dismissed g-k’s stale review via 4502f89 Mar 21, 2018

@jvehent
add handler tests for /sign/file
Verified
This commit was signed with a verified signature.
@jvehent jvehent Julien Vehent [:ulfr]
GPG key ID: A3D652173B763E8F Learn about signing commits
Loading status checks…
524c8d7

@jvehent jvehent merged commit 925f7fd into master Mar 22, 2018
2 of 3 checks passed

2 of 3 checks passed

coverage/coveralls Coverage increased (+0.8%) to 83.855%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment