New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please create tags for all lua-sandbox releases #156

Closed
rhertzog opened this Issue Sep 27, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@rhertzog
Copy link
Contributor

rhertzog commented Sep 27, 2016

I noticed that at the github releases pages has version 1.0.3 as the latest version, yet when you look at the history of https://github.com/mozilla-services/lua_sandbox/commits/master/CMakeLists.txt you will see version 1.0.4, 1.0.5 an 1.1.0.

I would highly recommend to not bump the version together with other changes. Make it a single commit changing only this and make a new tag pointing to this commit so that it's really clear that the new version is released (otherwise we might assume that you are only preparing the next release and bumped the version but you intend to make other changes before release).

Thank you. I noticed this while starting to work on a Debian package for lua-sandbox.

@rhertzog

This comment has been minimized.

Copy link
Contributor

rhertzog commented Sep 27, 2016

BTW same applies for hindsight (there it's even worse as there are no tags at all). If you want me to open the same ticket on hindsight, let me know. Otherwise I assume once is enough as it's about your release procedure, not really about the product itself.

@trink

This comment has been minimized.

Copy link
Collaborator

trink commented Sep 27, 2016

The version is bumped in a working branch once it is merged to master it is considered released. I will go back and tag the merges, thanks.

@trink

This comment has been minimized.

Copy link
Collaborator

trink commented Sep 27, 2016

As for Hindsight there will be no tagging while it is under heavy development. The master branch is the source of truth and there will be no support of previous versions. The versioning is strictly there for package dependency management.

@trink

This comment has been minimized.

Copy link
Collaborator

trink commented Sep 27, 2016

The tags have been added

@trink trink closed this Sep 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment