Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1595063 - Add ua attribution to environment data #494

Merged
merged 1 commit into from Feb 5, 2020
Merged

Bug 1595063 - Add ua attribution to environment data #494

merged 1 commit into from Feb 5, 2020

Conversation

@Mardak
Copy link
Contributor

@Mardak Mardak commented Feb 5, 2020

r?@acmiyaguchi Similar to #357 but for ua added in https://bugzilla.mozilla.org/show_bug.cgi?id=1595063

https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/environment.html

Checklist for reviewer:

  • Commits should reference a bug or github issue, if relevant
  • Scan the PR and verify that no changes (particularly to .circleci/config.yml) will cause environment variables (particularly credentials) to be exposed in test logs
  • Trigger the integration CI test by pushing this revision as discussed in the README and review the report posted in the comments.

For glean changes:

  • Update include/glean/CHANGELOG.md
@auto-assign auto-assign bot requested a review from akkomar Feb 5, 2020
@Mardak Mardak requested a review from acmiyaguchi Feb 5, 2020
@acmiyaguchi acmiyaguchi removed the request for review from akkomar Feb 5, 2020
@dataops-ci-bot

This comment has been minimized.

Copy link

@dataops-ci-bot dataops-ci-bot commented on f292baf Feb 5, 2020

Integration report for "Bug 1595063 - Add ua attribution to environment data"

Report for upstream
Report for latest commit

No changes detected.

Copy link
Contributor

@acmiyaguchi acmiyaguchi left a comment

r+

@acmiyaguchi
Copy link
Contributor

@acmiyaguchi acmiyaguchi commented Feb 5, 2020

You should expect to see this in telemetry.main on the day after the next deploy (or day of in the telemetry_live.main_v4 table). Deploys are manual, so the next deploy is likely to be Thursday 2020-02-07 UTC-ish due to PTO.

@acmiyaguchi acmiyaguchi merged commit 829c82e into mozilla-services:master Feb 5, 2020
3 checks passed
3 checks passed
ci/circleci: integrate Your tests passed on CircleCI!
Details
ci/circleci: post-artifacts Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
dataops-pipeline-schemas added a commit that referenced this pull request Feb 6, 2020
829c82e	2020-02-05 14:14:28 -0800	Bug 1595063 - Add ua attribution to environment data (#494)
acmiyaguchi pushed a commit that referenced this pull request Feb 13, 2020
3bd20bf	2020-02-12 13:03:15 -0800	Ignore only build at root directory; add java ignores (#506)
115682f	2020-02-11 17:53:36 -0800	Fix CI on master (#504)
815522b	2020-02-12 02:37:35 +0100	Bug 1602463 - Add a schema for the new default-browser ping (#495)
f8f7c08	2020-02-11 14:28:36 -0800	Replace validation testing with JSON Schema v7 compatible libraries  (#499)
457f05e	2020-02-11 12:19:49 -0800	Add validation test for null devices in syncs
7c8aa57	2020-02-11 12:19:49 -0800	Bug 1614418 allow null for syncs device versions
4017e78	2020-02-11 11:58:35 -0800	Add initial GRAVEYARD document (#502)
023537f	2020-02-10 09:31:40 -0400	bug 1604312 - Scalars can now appear in 'deletion-request' pings. (#481)
fb3c473	2020-02-07 16:43:00 -0500	error schema updates based on review
30947fe	2020-02-07 16:43:00 -0500	Bug 1613225 Add descriptions to payload_bytes_* fields
829c82e	2020-02-05 14:14:28 -0800	Bug 1595063 - Add ua attribution to environment data (#494)
63dcb42	2020-02-03 16:49:19 -0500	anyOf -> oneOf
0739fed	2020-02-03 16:49:19 -0500	Add CHANGELOG
36c965f	2020-02-03 16:49:19 -0500	1612940: Allow "null" extras in experiment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants