Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes that I forgot to push to my last PR #1283 #1331

Merged
merged 1 commit into from Jun 23, 2019

Conversation

CodeGains
Copy link
Contributor

Very minor changes that I forgot to push to my last PR, #1283. One of the code review comments was to rename toNameSchema to toPathSchema, which I thought was a good idea. The other change was to add lodash.get to the package.json.

Reasons for making this change

I realized I forgot to push these review changes before last PR was merged.

Checklist

  • I'm adding or updating code
    • I've added and/or updated tests

@epicfaace
Copy link
Member

Yeah, good point, sorry I forgot about those -- thanks for catching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants