This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Links for prepare_tlds.py & make_dafsa.py updated to pull from mozilla-central - #431
Merged
Merged
Conversation
Contributor
|
Fetching particular revision is definitely the safest way, and also guarantees reproducibility. If we use the tip, and some of those scripts gets broken, that means we can potentially break our whole user base if a bad dafsa gets published. Let's keep it that way, even if it means that we should redeploy the lambda everytime there's a change to take into account in the python scripts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Question: I've added links to the particular revisions, should we be pulling from the tip?