From 3586749ca73c5695ed820e784160401b7b099e73 Mon Sep 17 00:00:00 2001 From: Greg Guthe Date: Fri, 1 Sep 2017 18:18:35 -0400 Subject: [PATCH] fail server build for imports out of build/ and node_modules/ https://github.com/mozilla-services/screenshots/pull/3440#issuecomment-326625163 --- bin/build-scripts/bundle_dependencies | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/bin/build-scripts/bundle_dependencies b/bin/build-scripts/bundle_dependencies index fc3a357067..d1aaf3b3e2 100755 --- a/bin/build-scripts/bundle_dependencies +++ b/bin/build-scripts/bundle_dependencies @@ -33,6 +33,13 @@ build() { mkdir -p "$(dirname "$(depfile)")" echo -n "Building $(basename $dest): deps... " browserify --list -e "$@" | sed "s!$(pwd)/!!g" | grep -v build-time > "$(depfile)" + if egrep -qv "^(build|node_modules)/" "$(depfile)" ; then + echo + echo "error: $@ or its deps import files outside build/ or node_modules/:" + egrep -v "^(build|node_modules)/" "$(depfile)" + echo "failed." + exit 2 + fi echo -n "bundle... " NODE_ENV=production browserify -o "$dest" \ -g [ envify --NODE_ENV production ] \