Skip to content
This repository has been archived by the owner. It is now read-only.

Reimplement error message when shooting Page Shot pages #2237

Closed
ianb opened this issue Feb 28, 2017 · 2 comments
Closed

Reimplement error message when shooting Page Shot pages #2237

ianb opened this issue Feb 28, 2017 · 2 comments

Comments

@ianb
Copy link
Contributor

@ianb ianb commented Feb 28, 2017

Page Shot should give an error of some sort when you try to capture a Page Shot page. Or we could disable the button on those pages (perhaps the better answer, if it's not too hard).

@ckprice ckprice added this to the Page Shot in 54 milestone Mar 1, 2017
@ianb
Copy link
Contributor Author

@ianb ianb commented Mar 1, 2017

Note that the location of the service is in addon/webextension/background/main.js in main.getBackend() – if the button (browserAction) can be disabled anytime the active tab is on that domain then that would be great, if that's not possible then you can also just pop up an error message if someone attempts to start Page Shot on one of those pages.

@ianb ianb removed this from the Page Shot in 54 milestone Mar 9, 2017
@ianb ianb removed this from the Page Shot in 54 milestone Mar 9, 2017
@ianb ianb added this to the Sprint 54.2 milestone Mar 9, 2017
@ianb ianb added this to the Sprint 54.2 milestone Mar 9, 2017
@wresuolc wresuolc removed this from the Sprint 54.2 milestone Mar 20, 2017
@wresuolc wresuolc added this to the Sprint 54.3 milestone Mar 20, 2017
@wresuolc wresuolc added this to the Sprint 54.3 milestone Mar 20, 2017
@wresuolc wresuolc removed this from the Sprint 54.2 milestone Mar 20, 2017
@dannycoates
Copy link
Contributor

@dannycoates dannycoates commented Mar 22, 2017

This was done it #2368

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants