Skip to content
This repository has been archived by the owner. It is now read-only.

Notification icon for errors #2239

Closed
ianb opened this issue Feb 28, 2017 · 9 comments
Closed

Notification icon for errors #2239

ianb opened this issue Feb 28, 2017 · 9 comments

Comments

@ianb
Copy link
Contributor

@ianb ianb commented Feb 28, 2017

When errors occur we're going to pop up a notification. We should have some error icon to go on it. I can't find much information on expected sizes. Our other icon is 32px and seems fine.

Probably just a ! or something simple is all we need.

@ianb ianb added the needs:UX label Feb 28, 2017
@ckprice ckprice added this to the Page Shot in 54 milestone Mar 1, 2017
@johngruen
Copy link
Contributor

@johngruen johngruen commented Mar 7, 2017

here's a screenshot of an offending error message. We want to have a little icon here.

screen shot 2017-03-07 at 6 46 32 pm

@ianb
Copy link
Contributor Author

@ianb ianb commented Mar 7, 2017

It looks like a notification now, not a popup (that was the SDK version)

@TLHuang
Copy link

@TLHuang TLHuang commented Mar 15, 2017

Here is the current design for notification

4 3 notification for error

For the layout, please refer to the measurement -> 4.3 Notification for errer, and the illustration is updated here. Just a reminder, the current fox illustration you seen on the screen is a placeholder, we are still waiting for update from Sean Martell.

@wresuolc
Copy link
Contributor

@wresuolc wresuolc commented Mar 22, 2017

We're unable to do a popup like that in a web extension. Instead we've been using the built-in notifications. For this we'll need a small icon that will fit in the regular notifications. /cc @TLHuang @johngruen

@ianb
Copy link
Contributor Author

@ianb ianb commented Mar 27, 2017

The icon we need is one that fits in the same place as the copy icon in this popup:

image

@ckprice
Copy link

@ckprice ckprice commented Mar 28, 2017

@ckprice will hunt down an icon, but not a blocker.

@TLHuang
Copy link

@TLHuang TLHuang commented Mar 29, 2017

Sorry for the late reply. May I know why we can use popup when it was on Test Pilot, but now we can only use built-in notification for Firefox Screenshots? I can provide an icon for the notification, just want to know if it's the only way we can do.

@jaredhirsch
Copy link
Member

@jaredhirsch jaredhirsch commented Mar 29, 2017

@TLHuang Yup, we removed the SDK code and ported to a webextension, which doesn't support doorhangers

@ChenMorpheus
Copy link

@ChenMorpheus ChenMorpheus commented Mar 30, 2017

Notification serves as a message to notify users, but it's not for error cases, especially the notification might be pretty far away from where users trigger it, so it would be inappropriate to have notification here.

Is there any alternative solution or will webextension support door hanger later? If not, since we won't provide the reason why it's unavailable, I would prefer to have an unavailable badge or only disable the icon on the toolbar to imply Fx Screenshots is not able to be used at this moment. You can check the mockups below.

2017-03-30 3 17 57

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants